Skip to content

fix(amazonq): fix pair programmer card never shown #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
agenticMode: true,
quickActionCommands: commands,
disclaimerAcknowledged: ${MeetQSettings.getInstance().disclaimerAcknowledged},
pairProgrammingAcknowledged: ${!MeetQSettings.getInstance().amazonQChatPairProgramming}
pairProgrammingAcknowledged: ${MeetQSettings.getInstance().pairProgrammingAcknowledged}

Check warning on line 153 in plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/Browser.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/Browser.kt#L153

Added line #L153 was not covered by tests
},
hybridChatConnector,
${CodeWhispererFeatureConfigService.getInstance().getFeatureConfigJsonString()}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@
CHAT_PROMPT_OPTION_ACKNOWLEDGED -> {
val acknowledgedMessage = node.params?.get("messageId")
if (acknowledgedMessage?.asText() == "programmerModeCardId") {
MeetQSettings.getInstance().amazonQChatPairProgramming = false
MeetQSettings.getInstance().pairProgrammingAcknowledged = true

Check warning on line 431 in plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt#L431

Added line #L431 was not covered by tests
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@
state.disclaimerAcknowledged = value
}

var amazonQChatPairProgramming: Boolean
get() = state.amazonQChatPairProgramming
var pairProgrammingAcknowledged: Boolean
get() = state.pairProgrammingAcknowledged

Check warning on line 42 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/settings/MeetQSettings.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/settings/MeetQSettings.kt#L42

Added line #L42 was not covered by tests
set(value) {
state.amazonQChatPairProgramming = value
state.pairProgrammingAcknowledged = value

Check warning on line 44 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/settings/MeetQSettings.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/settings/MeetQSettings.kt#L44

Added line #L44 was not covered by tests
}

companion object {
Expand All @@ -52,5 +52,5 @@
var shouldDisplayPage: Boolean = true,
var reinvent2024OnboardingCount: Int = 0,
var disclaimerAcknowledged: Boolean = false,
var amazonQChatPairProgramming: Boolean = false,
var pairProgrammingAcknowledged: Boolean = false,

Check warning on line 55 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/settings/MeetQSettings.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/settings/MeetQSettings.kt#L55

Added line #L55 was not covered by tests
)
Loading