Skip to content

fix(amazonq): fix inline pagination logic and corountine scope logic #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2025

Conversation

andrewyuq
Copy link
Contributor

  1. Show the configurable tab action only on new auto trigger UX(A/B)
  2. remove disposableCoroutineScope usage and directly check the dispose state of the popup(session validity)
  3. use partialResultToken instead of workdoneToken for pagination logic with flare

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andrewyuq andrewyuq requested review from a team as code owners May 14, 2025 01:29
@rli rli merged commit 760f08f into aws:feature/q-lsp-chat May 15, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants