refactor(amazonq): remove redunant panel re-creation #5729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Will-ShaoHua
commented
May 16, 2025
| @@ -85,8 +85,7 @@ class AmazonQToolWindowFactory : ToolWindowFactory, DumbAware { | |||
| object : BearerTokenProviderListener { | |||
| override fun onChange(providerId: String, newScopes: List<String>?) { | |||
| if (ToolkitConnectionManager.getInstance(project).connectionStateForFeature(QConnection.getInstance()) == BearerTokenAuthState.AUTHORIZED) { | |||
| AmazonQToolWindow.getInstance(project).disposeAndRecreate() | |||
There was a problem hiding this comment.
not necessary to re-init an entire new panel
Will-ShaoHua
commented
May 16, 2025
| @@ -98,13 +97,12 @@ class AmazonQToolWindowFactory : ToolWindowFactory, DumbAware { | |||
| // note we name myProject intentionally ow it will shadow the "project" provided by the IDE | |||
| override fun onProfileSelected(myProject: Project, profile: QRegionProfile?) { | |||
| if (project.isDisposed) return | |||
| AmazonQToolWindow.getInstance(project).disposeAndRecreate() | |||
There was a problem hiding this comment.
TODO: send active profile to LSP so that LSP can render selected profile in a card
Will-ShaoHua
changed the title
rli
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
related to https://youtrack.jetbrains.com/issue/IJPL-186252
if disposeAndRecreate gets called multiple times within short duration, i will crash the IDE.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.