fix(amazonq): Fix prompt file not opening in windows #5750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
bryceitoc9
approved these changes
May 22, 2025
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
May 22, 2025
| @@ -146,20 +148,20 @@ class AmazonQLanguageClientImpl(private val project: Project) : AmazonQLanguageC | |||
| if (params.uri.isNullOrEmpty()) { | |||
| return CompletableFuture.completedFuture(ShowDocumentResult(false)) | |||
| } | |||
|
|
|||
| val fileToOpen = URLDecoder.decode(params.uri, StandardCharsets.UTF_8.name()) | |||
There was a problem hiding this comment.
please include inline comment why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
File URI sent by the server is encoded. This is not recognized as a valid path by JB in Windows. Decoding the path to UTF-8 charset.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.