Skip to content

config(amazonq): extend sso oidc client timeout to 12s #5755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented May 23, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Corresponding VSC change
aws/aws-toolkit-vscode#7367

In ticket V1761315147 it was being reported that createToken could take 9 seconds. This would mean that the SSO client API request would time out

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua marked this pull request as draft May 23, 2025 01:09
@Will-ShaoHua
Copy link
Contributor Author

wont merge until wip release 1.72.0 is complete

@Will-ShaoHua Will-ShaoHua changed the title extend sso oidc client timeout to 12s config(amazonq): extend sso oidc client timeout to 12s May 23, 2025
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review May 23, 2025 13:20
@Will-ShaoHua Will-ShaoHua merged commit ea1d440 into aws:main May 23, 2025
11 of 12 checks passed
@Will-ShaoHua Will-ShaoHua deleted the sso branch May 23, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants