poll for ACA properly

Author: David Hasani

packages/core/src/codewhisperer/commands/startTransformByQ.ts

@@ -641,6 +641,7 @@ export async function setTransformationToRunningState() {
     transformByQState.resetSessionJobHistory()
     transformByQState.setJobId('') // so that details for last job are not overwritten when running one job after another
     transformByQState.setPolledJobStatus('') // so that previous job's status does not display at very beginning of this job
+    transformByQState.setHasSeenTransforming(false)
 
     CodeTransformTelemetryState.instance.setStartTime()
     transformByQState.setStartTime(

packages/core/src/codewhisperer/models/model.ts

@@ -776,6 +776,8 @@ export class TransformByQState {
 
     private polledJobStatus: string = ''
 
+    private hasSeenTransforming: boolean = false
+
     private payloadFilePath: string = ''
 
     private jobFailureErrorNotification: string | undefined = undefined
@@ -823,6 +825,10 @@ export class TransformByQState {
         return this.transformByQState === TransformByQStatus.PartiallySucceeded
     }
 
+    public getHasSeenTransforming() {
+        return this.hasSeenTransforming
+    }
+
     public getTransformationType() {
         return this.transformationType
     }
@@ -995,6 +1001,10 @@ export class TransformByQState {
         this.transformByQState = TransformByQStatus.PartiallySucceeded
     }
 
+    public setHasSeenTransforming(hasSeen: boolean) {
+        this.hasSeenTransforming = hasSeen
+    }
+
     public setTransformationType(type: TransformationType) {
         this.transformationType = type
     }
@@ -1137,6 +1147,7 @@ export class TransformByQState {
 
     public setJobDefaults() {
         this.setToNotStarted()
+        this.hasSeenTransforming = false
         this.jobFailureErrorNotification = undefined
         this.jobFailureErrorChatMessage = undefined
         this.payloadFilePath = ''

packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts

@@ -654,6 +654,9 @@ export async function pollTransformationJob(jobId: string, validStates: string[]
             if (CodeWhispererConstants.validStatesForBuildSucceeded.includes(status)) {
                 jobPlanProgress['buildCode'] = StepProgress.Succeeded
             }
+            if (status === 'TRANSFORMING') {
+                transformByQState.setHasSeenTransforming(true)
+            }
             // emit metric when job status changes
             if (status !== transformByQState.getPolledJobStatus()) {
                 telemetry.codeTransform_jobStatusChanged.emit({
@@ -696,11 +699,9 @@ export async function pollTransformationJob(jobId: string, validStates: string[]
                 break
             }
 
-            // TO-DO: make sure we are not in AWAITING_CLIENT_ACTION while job is in PLANNING state
-            // (that should only happen in interactive mode; IDE is always non-interactive)
-            // otherwise below need to change *status === 'TRANSFORMING'* to *jobPlanProgress['generatePlan'] === StepProgress.Succeeded*
+            // TO-DO: later, handle case where PlannerAgent needs to run mvn dependency:tree during PLANNING stage; not needed for now
             if (
-                status === 'TRANSFORMING' &&
+                transformByQState.getHasSeenTransforming() &&
                 transformByQState.getTransformationType() === TransformationType.LANGUAGE_UPGRADE
             ) {
                 // client-side build is N/A for SQL conversions