add check for empty diff

Author: David Hasani

packages/core/src/codewhisperer/commands/startTransformByQ.ts

@@ -684,6 +684,7 @@ export async function postTransformationJob() {
         codeTransformJobId: transformByQState.getJobId(),
         codeTransformResultStatusMessage: resultStatusMessage,
         codeTransformRunTimeLatency: durationInMs,
+        reason: transformByQState.getPolledJobStatus(),
         result:
             transformByQState.isSucceeded() || transformByQState.isPartiallySucceeded()
                 ? MetadataResult.Pass

packages/core/src/codewhisperer/models/constants.ts

@@ -653,7 +653,7 @@ export const receivedValidConfigFileMessage =
     'The dependency upgrade file looks good. I will use this information to upgrade the dependencies you specified.'
 
 export const chooseConfigFileMessage =
-    'Would you like to provide a dependency upgrade file? You can specify first and third party dependencies and their versions in a YAML or JSON file, and I will upgrade them during the transformation. For an example dependency upgrade file, see the [documentation](https://docs.aws.amazon.com/amazonq/latest/qdeveloper-ug/code-transformation.html#dependency-upgrade-file).'
+    'Would you like to provide a dependency upgrade file? You can specify first and third party dependencies and their versions in a YAML file, and I will upgrade them during the transformation. For an example dependency upgrade file, see the [documentation](https://docs.aws.amazon.com/amazonq/latest/qdeveloper-ug/code-transformation.html#dependency-upgrade-file).'
 
 export const enterJavaHomePlaceholder = 'Enter the path to your Java installation'
 

packages/core/src/codewhisperer/models/model.ts

@@ -675,8 +675,12 @@ export class ZipManifest {
     version: string = '1.0'
     hilCapabilities: string[] = ['HIL_1pDependency_VersionUpgrade']
     // TO-DO: add something like AGENTIC_PLAN_V1 here when BE allowlists everyone
+    // TO-DO: is SELECTIVE_TRANSFORMATION_V2 needed here?
     transformCapabilities: string[] = ['EXPLAINABILITY_V1', 'CLIENT_SIDE_BUILD']
     dependencyUpgradeConfigFile?: string = undefined
+    // TODO: make sure the below 2 keys don't mess up SQL conversions when present
+    noInteractiveMode: boolean = true
+    compilationsJsonFile: string = 'compilations.json'
     customBuildCommand: string = 'clean test'
     requestedConversions?: {
         sqlConversion?: {

packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts

@@ -696,6 +696,9 @@ export async function pollTransformationJob(jobId: string, validStates: string[]
                 break
             }
 
+            // TO-DO: make sure we are not in AWAITING_CLIENT_ACTION while job is in PLANNING state
+            // (that should only happen in interactive mode; IDE is always non-interactive)
+            // otherwise below need to change *status === 'TRANSFORMING'* to *jobPlanProgress['generatePlan'] === StepProgress.Succeeded*
             if (
                 status === 'TRANSFORMING' &&
                 transformByQState.getTransformationType() === TransformationType.LANGUAGE_UPGRADE
@@ -769,7 +772,13 @@ async function attemptLocalBuild() {
         getLogger().info(
             `CodeTransformation: downloaded clientInstructions with diff.patch at: ${clientInstructionsPath}`
         )
-        await processClientInstructions(jobId, clientInstructionsPath, artifactId)
+        const diffContents = await fs.readFileText(clientInstructionsPath)
+        // make sure diff.patch is not empty
+        if (diffContents.trim()) {
+            await processClientInstructions(jobId, clientInstructionsPath, artifactId)
+        } else {
+            getLogger().info('CodeTransformation: diff.patch is empty, skipping client-side build for this iteration')
+        }
     }
 }