Commit e369ff3
authored
fix(smus): Improve error handling when the Space takes too long to start (#8277)
## Problem
Occasionally, then a user clicks the Connect button for a Space that is
in the Stopped status, the corresponding App that gets created
eventually takes too long to become Running, so the user is shown the
following error message.
```
Remote connection failed: Timed out waiting for app "default-b97e54b8-e0e1-70b7-a216-856fcbb3cc61" to reach "InService" status. | Timed out waiting for app "default-b97e54b8-e0e1-70b7-a216-856fcbb3cc61" to reach "InService" status.
```
We can't prevent this from happening as it depends on the SageMaker
platform, but we can improve the user experience around this.
## Solution
* Add more time to hard timeout
* update the process messages when App takes longer than usual to
connect
## Appearance
### currently:
<img width="474" height="67" alt="Screenshot 2025-11-12 at 12 13 53 PM
(3)"
src="https://github.com/user-attachments/assets/2b543afa-621f-4ac0-8838-3b1d0ca74276"
/>
(2 min 30 sec)
->
<img width="469" height="161" alt="Screenshot 2025-11-12 at 12 05 16 PM"
src="https://github.com/user-attachments/assets/ce4d7f3f-7d52-48ed-937d-b07a7e09175d"
/>
### this change:
<img width="474" height="67" alt="Screenshot 2025-11-12 at 12 13 53 PM
(3)"
src="https://github.com/user-attachments/assets/2b543afa-621f-4ac0-8838-3b1d0ca74276"
/>
(1 min)
->
**Note: Based on @dylanraws' and ricokyle@'s suggestions, the exact
wording is changed to "Connecting to testX: Starting the Space is taking
longer than usual. The space will connect when ready"**
<img width="478" height="127" alt="Screenshot 2025-11-11 at 10 02 37 AM"
src="https://github.com/user-attachments/assets/b9d0c4b2-e25b-4c05-8ea5-ecb65c9b3fa5"
/>
(9 min)
->
<img width="469" height="161" alt="Screenshot 2025-11-12 at 12 05 16 PM"
src="https://github.com/user-attachments/assets/ce4d7f3f-7d52-48ed-937d-b07a7e09175d"
/>
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.1 parent 8d1eb19 commit e369ff3
3 files changed
+32
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
341 | 341 | | |
342 | 342 | | |
343 | 343 | | |
344 | | - | |
| 344 | + | |
| 345 | + | |
345 | 346 | | |
346 | 347 | | |
347 | 348 | | |
| |||
385 | 386 | | |
386 | 387 | | |
387 | 388 | | |
388 | | - | |
| 389 | + | |
| 390 | + | |
389 | 391 | | |
390 | 392 | | |
391 | 393 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
| 1 | + | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| |||
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
62 | 67 | | |
63 | 68 | | |
64 | 69 | | |
| |||
364 | 369 | | |
365 | 370 | | |
366 | 371 | | |
367 | | - | |
368 | | - | |
| 372 | + | |
369 | 373 | | |
370 | | - | |
| 374 | + | |
371 | 375 | | |
372 | 376 | | |
373 | 377 | | |
| |||
383 | 387 | | |
384 | 388 | | |
385 | 389 | | |
386 | | - | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
387 | 397 | | |
388 | 398 | | |
389 | 399 | | |
| |||
Lines changed: 12 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
258 | 266 | | |
259 | 267 | | |
260 | 268 | | |
| |||
0 commit comments