test: add tests for logic

Author: Hweinstock

packages/amazonq/src/lsp/config.ts

@@ -3,9 +3,11 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import { DevSettings, getServiceEnvVarConfig, Settings } from 'aws-core-vscode/shared'
+import { DevSettings, getLogger, getServiceEnvVarConfig, Settings } from 'aws-core-vscode/shared'
 import { LspConfig } from 'aws-core-vscode/amazonq'
 
+// Taken from https://github.com/aws/language-server-runtimes/blob/eae85672c345d8adaf4c8cbd741260b8a59750c4/runtimes/runtimes/util/loggingUtil.ts#L4-L10
+const validLspLogLevels = ['error', 'warn', 'info', 'log', 'debug']
 export interface ExtendedAmazonQLSPConfig extends LspConfig {
     ui?: string
 }
@@ -31,9 +33,21 @@ export function getAmazonQLspConfig(): ExtendedAmazonQLSPConfig {
 export function getLspLogSettings(clientId: string) {
     const traceServerSetting = `${clientId}.trace.server`
     const lspLogLevelSetting = `${clientId}.lsp.logLevel`
+    const seperateTraceChannel = Settings.instance.get(traceServerSetting)
+    const lspLogLevel = Settings.instance.get(lspLogLevelSetting, String, 'info')
+
+    if (!validLspLogLevels.includes(lspLogLevel)) {
+        getLogger('amazonqLsp').warn(
+            `Invalid log level for ${lspLogLevelSetting}: ${lspLogLevel}. Defaulting to 'info'.`
+        )
+        return {
+            seperateTraceChannel,
+            lspLogLevel: 'info',
+        }
+    }
 
     return {
-        seperateTraceChannel: Settings.instance.get(traceServerSetting),
-        lspLogLevel: Settings.instance.get(lspLogLevelSetting, String, 'info'),
+        seperateTraceChannel,
+        lspLogLevel: lspLogLevel,
     }
 }

packages/amazonq/test/unit/amazonq/lsp/chat/config.test.ts

@@ -0,0 +1,21 @@
+/*!
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import assert from 'assert'
+import { sanitizeLogLevel } from '../../../../../src/lsp/config'
+
+describe('sanitizeLogLevel', function () {
+    it('should return the log level if it is valid', function () {
+        const logLevel = 'info'
+        const sanitizedLogLevel = sanitizeLogLevel(logLevel)
+        assert.strictEqual(sanitizedLogLevel, logLevel)
+    })
+
+    it('should default to info if it is invalid', function () {
+        const logLevel = 'verbose'
+        const sanitizedLogLevel = sanitizeLogLevel(logLevel)
+        assert.strictEqual(sanitizedLogLevel, 'info')
+    })
+})