telemetry(amazonq): Adding cwsprChatProgrammingLanguage parameter to insertAtCursor and CopyAtClipboard events #5768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
justinmk3
reviewed
Oct 11, 2024
packages/core/src/codewhispererChat/controllers/chat/messenger/messenger.ts
Outdated
Show resolved
Hide resolved
justinmk3
approved these changes
Oct 11, 2024
…d added test cases for this function
laileni-aws
changed the title
laileni-aws
changed the title
ivikash
reviewed
Oct 15, 2024
| codeBlockIndex, | ||
| totalCodeBlocks, | ||
| messageUserIntentMap.get(messageId) ?? undefined | ||
| responseMetadata.get(messageId)?.[0] ?? undefined, |
Member
There was a problem hiding this comment.
We should add these to ViewDiff and AcceptDiff as well.
Contributor
Author
There was a problem hiding this comment.
Yes, that can be in different PR as these two are unavailable for Generate Tests(Beta).
@ivikash Correct me on this!
Contributor
use |
Contributor
|
Thanks for upstreaming the metric to common. The build is failing because the old local metric still exists and overrides the common one. You need to delete it (in this PR): |
tverney
pushed a commit
to tverney/aws-toolkit-vscode
that referenced
this pull request
Oct 21, 2024
…opyAtClipboard aws#5768 ## Problem - Client side telemetry event `interactWithMessage` is missing `cwsprChatProgrammingLanguage` parameter which helps to understand the language of generated code. ## Solution - Added `cwsprChatProgrammingLanguage` parameter for insertAtCursor and CopyAtClipboard events. - No Test cases were added in this PR. - Added `extractCodeBlockLanguage` function as current UTG Sync API sends python and java in the first chunk of generated code but thats the not case for other languages. To counter this, I am checking entire response for generated code language and emitting those metrics. - Added `cwsprChatProgrammingLanguage` in [commons](https://github.com/aws/aws-toolkit-common) package: aws/aws-toolkit-common#883 - Added `cwsprChatHasProjectContext and cwsprChatTotalCodeBlocks` in in [commons](https://github.com/aws/aws-toolkit-common) package: aws/aws-toolkit-common#884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
interactWithMessageis missingcwsprChatProgrammingLanguageparameter which helps to understand the language of generated code.Solution
cwsprChatProgrammingLanguageparameter for insertAtCursor and CopyAtClipboard events.extractCodeBlockLanguagefunction as current UTG Sync API sends python and java in the first chunk of generated code but thats the not case for other languages. To counter this, I am checking entire response for generated code language and emitting those metrics.cwsprChatProgrammingLanguagein commons package: telemetry: Adding cwsprChatProgrammingLanguage aws-toolkit-common#883cwsprChatHasProjectContext and cwsprChatTotalCodeBlocksin in commons package: telemetry: cwsprChatHasProjectContext and cwsprChatTotalCodeBlocks aws-toolkit-common#884License: I confirm that my contribution is made under the terms of the Apache 2.0 license.