fix(amazonq): always use projectName in zipEntryPath #6182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
laileni-aws
approved these changes
Dec 9, 2024
jpinkney-aws
reviewed
Dec 9, 2024
| @@ -112,6 +113,32 @@ describe('zipUtil', function () { | |||
| ) | |||
| assert.equal(zipMetadata2.lines, zipMetadata.lines + 1) | |||
| }) | |||
|
|
|||
| it('should handle path with repeated project name for file scan', async function () { | |||
| const appCodePathWithRepeatedProjectName = join(workspaceFolder, 'workspaceFolder', 'App.java') | |||
There was a problem hiding this comment.
Can you pull this out of this test, it looks like you're using it 4 times
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem Projects with a nested folder of the same name does not scan properly. For example if the project name is `foo`, and there exists a folder `foo/foo/` then the zip artifact only contains the inner `foo/` folder. ## Solution Always include the project name in the zip artifact instead of conditionally adding it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Projects with a nested folder of the same name does not scan properly.
For example if the project name is
foo, and there exists a folderfoo/foo/then the zip artifact only contains the innerfoo/folder.Solution
Always include the project name in the zip artifact instead of conditionally adding it.
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.