Add support for device_code flow by selecting a checkbox #7371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
May 23, 2025
| @@ -50,6 +50,7 @@ export type globalKey = | |||
| | 'aws.amazonq.customization.overrideV2' | |||
| | 'aws.amazonq.regionProfiles' | |||
| | 'aws.amazonq.regionProfiles.cache' | |||
| | 'aws.forceDeviceCodeFlow' // Toggle to force device code flow for authentication | |||
There was a problem hiding this comment.
Why store the flag permanently? It might be useful as a one-time choice, but storing it as a permanent choice raises the security risk of this feature.
There was a problem hiding this comment.
The current implementation logic only stores temporarily the settings. When the authentication process begins, it revert the setting to undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
VSCode extension automatically launch authorization_code flow when performing an enterprise authentication and VSCode is running locally.
In some case, VSCode might be running on a computer that cannot perform the enterprise authentication (e.g Virtual Desktop). In this case, it might be useful for end-user to be able to select the device code authentication flow to be able to complete the authentication from another computer.
Solution
This PR implements a checkbox in the login UI to allow the user to select the device code flow (similar process as for remote extension) and then allows the user to copy the authentication URL and use it from the computer which can actually authenticate.
By default the checkbox is not checked.
After successful authentication, the checkbox is reset.
feature/xbranches will not be squash-merged at release time.