Skip to content

feat(lsp): forward chatOptionsUpdate to ui #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented May 28, 2025

Problem

chatOptionsUpdate notifications are not forwarded to UI.

This is needed to persist previously selected model in new tabs.

Solution

Forward chatOptionsUpdate notifications to UI

Related PR: aws/language-server-runtimes#530


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@ctlai95 ctlai95 marked this pull request as ready for review May 29, 2025 18:28
@ctlai95 ctlai95 requested a review from a team as a code owner May 29, 2025 18:28
@ctlai95 ctlai95 merged commit 12eece1 into aws:master May 30, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants