Skip to content

feat(lambda): Add handler for upcoming Lambda URI #7453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rhamilt
Copy link

@rhamilt rhamilt commented Jun 9, 2025

Problem

The Lambda team plans to add a URI handler to act as an entrypoint to the toolkit from a URL. This will be fully available in an upcoming toolkit release, but customers who don't have that version will not get the benefit of the handler.

Solution

Add a handler ahead of time telling customers to update to the latest version. This way, customers who have an older version with this change will be notified that the functionality they are trying to use is in a newer version. This should help customers from becoming confused when they open a link and an older version says it is not handled.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rhamilt rhamilt requested a review from a team as a code owner June 9, 2025 20:50
Copy link

github-actions bot commented Jun 9, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

}

return vscode.Disposable.from(
globals.uriHandler.onPath('/lambda/load-function', openFunctionHandler, parseOpenParams)
Copy link
Contributor

@justinmk3 justinmk3 Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for re-using the existing module and patterns.

@rhamilt rhamilt closed this Jun 17, 2025
@rhamilt rhamilt reopened this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants