Removing manually setting job status to failed after any error from cwspr API (#455)

* removing manually setting job status to failed after any error from cwspr API

Author: pranav-firake

server/aws-lsp-codewhisperer/src/language-server/netTransform/tests/transformHandler.test.ts

@@ -209,7 +209,7 @@ describe('Test Transform handler ', () => {
             const request = JSON.parse(requestString) as GetTransformRequest
             const res = await transformHandler.getTransformation(request)
 
-            expect(res.TransformationJob.status).to.equal('COMPLETED')
+            expect(res?.TransformationJob.status).to.equal('COMPLETED')
         })
     })
 
@@ -233,7 +233,7 @@ describe('Test Transform handler ', () => {
             const request = JSON.parse(requestString) as GetTransformRequest
             const res = await transformHandler.getTransformation(request)
 
-            expect(res.TransformationJob.status).to.equal('FAILED')
+            expect(res?.TransformationJob.status).to.equal('FAILED')
         })
     })
 

server/aws-lsp-codewhisperer/src/language-server/netTransform/transformHandler.ts

@@ -187,10 +187,7 @@ export class TransformHandler {
         } catch (e: any) {
             const errorMessage = (e as Error).message ?? 'Error in GetTransformation API call'
             this.logging.log('Error: ' + errorMessage)
-
-            return {
-                TransformationJob: { status: 'FAILED' },
-            } as GetTransformResponse
+            return null
         }
     }
     async getTransformationPlan(request: GetTransformPlanRequest) {
@@ -344,7 +341,7 @@ export class TransformHandler {
                     this.logging.log(
                         `CodeTransformation: GetTransformation failed after ${getTransformMaxAttempts} attempts.`
                     )
-                    status = PollTransformationStatus.FAILED
+                    status = PollTransformationStatus.NOT_FOUND
                     break
                 }
 

server/aws-lsp-codewhisperer/src/language-server/netTransformServer.ts

@@ -68,7 +68,9 @@ export const QNetTransformServerToken =
                         const request = params as GetTransformRequest
                         logging.log('Calling getTransform request with job Id: ' + request.TransformationJobId)
                         const response = await transformHandler.getTransformation(request)
-                        emitTransformationJobReceivedTelemetry(telemetry, response)
+                        if (response != null) {
+                            emitTransformationJobReceivedTelemetry(telemetry, response)
+                        }
                         return response
                     }
                     case PollTransformCommand: {