feat: add fileUri to FileContext #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiGaCu
force-pushed
the
file_uri
branch
4 times, most recently
from
72c94cd to
e347b7a
Compare
natdurlik
approved these changes
May 21, 2025
ege0zcan
approved these changes
May 21, 2025
wweitao
pushed a commit
to LiGaCu/language-servers
that referenced
this pull request
May 22, 2025
Co-authored-by: Jiatong Li <jiatonli@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to coordinate the new aws/language-servers change, GenerateCompletions requests would start expecting the
fileUrifield to be set.We implemented this in both VSCode and JetBrains extensions, but as we are migrating GenerateCompletions away from them to
aws/language-servers, we also need to ensure they are added in the relevant code paths here.Solution
Add
fileUrito FileContextLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.