-
Notifications
You must be signed in to change notification settings - Fork 83
feat(amazon q): Enhancing the ux for modified files #2461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amazon q): Enhancing the ux for modified files #2461
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/upgrade-modified-files-ux #2461 +/- ##
=====================================================================
- Coverage 62.73% 62.49% -0.25%
=====================================================================
Files 266 266
Lines 59697 60109 +412
Branches 3842 3865 +23
=====================================================================
+ Hits 37451 37563 +112
- Misses 22170 22470 +300
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Will Lo <96078566+Will-ShaoHua@users.noreply.github.com>
…ocalProjectContextServer changes
Co-authored-by: aws-toolkit-automation <>
| }, | ||
| ], | ||
| modifiedFilesTracker: { | ||
| title: 'Following files were modified : ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We need to change this string!
| buttons: [{ id: BUTTON_UNDO_CHANGES, text: 'Undo', icon: 'undo' }], | ||
| }, | ||
| modifiedFilesTracker: { | ||
| title: 'Following files were modified : ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declare const and assign wherever its been used!
|
Approved for testing! |
* chore: add the dummpy package back the the script * chore: fix the zip to cp * chore: move the file into zip folder
aws#2475) * feat: differenciate implicit and explicit reject for inline completion * fix: add UT for inline reject metric type
Co-authored-by: Boyu <bywang@amazon.com>
* fix: McpManager not initialized error * fix: adding more try catch to avoid crashes due to mcpmanager initialization error * fix: adding error to debug logs
62b4a0e
into
aws:feature/upgrade-modified-files-ux
Problem
Created a new component in the mynah-ui, to display modified files along with per file undo button and undoall button for more than one files. Instead of sending duplicate data, added additional properties in existing data and rendered them in new component
Solution
For every time a file is modified, adding a new property "modifiedFilesTracker" to the chatMessage/chatItem to send to the UI with modified file details and undo buttons. With this, same file details will be shown in 2 places and will have capability to undo from any place
Concerns :
Without creating the "LocalProjectContextController" fallback instance, seeing the following error which is breaking the functionality completely :
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.