feat: Add as_ptr() API for Config
#5274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
force-pushed
the
config-as-ptr
branch
from
44bd7a3 to
46a3865
Compare
goatgoose
commented
Apr 25, 2025
| @@ -43,6 +43,7 @@ KNOWN_MISSES=( | |||
| "s2n_config_set_ctx" | |||
| "s2n_client_hello_has_extension" | |||
| "s2n_async_pkey_op_perform" | |||
| "s2n_config_get_client_auth_type" | |||
There was a problem hiding this comment.
My test makes use of s2n_config_get_client_auth_type which causes grep_simple_mistakes to complain about missing documentation. I figured this exception was ok since I don't expect us to expose s2n_config_get_client_auth_type() in the Rust bindings anytime soon. But let me know if you think this exception isn't ideal and I can think of another test.
goatgoose
force-pushed
the
config-as-ptr
branch
from
46a3865 to
bf6472c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Allows access to the underlying s2n_tls_sys s2n_config pointer from the
config::Builderfor external builds, similar to #5229. This allows applications to directly call s2n_tls_sys s2n_config APIs when a higher-level API isn't provided.Testing:
I added a new test to ensure that the new API can be used to call an s2n-tls-sys API. The external build test added in #5229 ensures that this test is running in CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.