Closed
Description
Description
After I reported #3600 about Pydantic 1.10.15, the release of Pydantic 1.10.16 fixed the problem – but then 1.10.17 broke it again.
Steps to reproduce
$ gh repo clone aws/serverless-application-model
$ cd serverless-application-model
$ python3 -m venv _e
$ . _e/bin/activate
(_e) $ pip install -e .[dev]
(_e) $ pip install pydantic==1.10.17
(_e) $ make test
Interestingly, I can also reproduce this on the develop
branch, which includes #3611 – using either pydantic==1.10.15
or pydantic==1.10.17
– so it doesn’t look like that PR works as intended.
Observed result
=========================================================================================== short test summary info ============================================================================================
FAILED tests/model/test_resource_validator.py::TestResourceValidatorFailure::test_connector_with_empty_properties - AttributeError: module 'pydantic.v1' has no attribute 'error_wrappers'
FAILED tests/model/test_resource_validator.py::TestResourceValidatorFailure::test_connector_with_invalid_permission - AttributeError: module 'pydantic.v1' has no attribute 'error_wrappers'
FAILED tests/model/test_resource_validator.py::TestResourceValidatorFailure::test_connector_with_invalid_permission_type - AttributeError: module 'pydantic.v1' has no attribute 'error_wrappers'
FAILED tests/model/test_resource_validator.py::TestResourceValidatorFailure::test_connector_without_source - AttributeError: module 'pydantic.v1' has no attribute 'error_wrappers'
FAILED tests/translator/test_translator.py::test_transform_invalid_document[error_graphqlapi] - AttributeError: module 'pydantic.v1' has no attribute 'error_wrappers'
============================================================================== 5 failed, 3967 passed, 5 rerun in 99.69s (0:01:39) ==============================================================================
Expected result
(_e) $ pip install pydantic==1.10.16
(_e) $ make test
======================================================================================= 3972 passed in 103.12s (0:01:43) =======================================================================================
Additional environment details
- OS: Fedora 40
x86_64
- If using the SAM CLI,
sam --version
: N/A - AWS region: N/A