-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Closed as not planned
Labels
stage/needs-triageAutomatically applied to new issues and PRs, indicating they haven't been looked at.Automatically applied to new issues and PRs, indicating they haven't been looked at.
Description
Description
Pydantic was updated to the 2nd version but the library pins it to the 1st version. I checked the latest pydantic version (2.8.2) and all tests passed. (also successfully tested the Pydantic 2.0.0)
It's needed to minimize version conflicts in environments.
Related issue: #3617
Steps to reproduce
$git clone https://github.com/aws/serverless-application-model.git
$ cd serverless-application-model
$ python3 -m venv _e
$ . _e/bin/activate
(_e) $ pip install "-e .[dev]"
(_e) $ pip install pydantic==2.8.2
(_e) $ make testObserved result
(_e) $ pip install pydantic==2.8.2
(_e) $ make test
Required test coverage of 95% reached. Total coverage: 95.85%
================================================================= 3988 passed in 72.79s (0:01:12) =================================================================Additional environment details
OS: MacOS Sonoma 14.6.1 aarch64
If using the SAM CLI, sam --version: N/A
AWS region: N/A
Metadata
Metadata
Assignees
Labels
stage/needs-triageAutomatically applied to new issues and PRs, indicating they haven't been looked at.Automatically applied to new issues and PRs, indicating they haven't been looked at.