Skip to content

Commit 93f0833

Browse files
enriquhlmouhib
authored andcommitted
Rebase with main
1 parent e4638de commit 93f0833

File tree

3 files changed

+57
-20
lines changed

3 files changed

+57
-20
lines changed

framework/API.md

Lines changed: 48 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

framework/src/consumption/lib/quicksight/quicksight-subscription-props.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import { Duration, RemovalPolicy } from 'aws-cdk-lib';
1111
export interface QuickSightSubscriptionProps {
1212

1313
/**
14-
* The name of your Amazon QuickSight account.
15-
* This name is unique over all of Amazon Web Services, and it appears only when users sign in.
14+
* The name of your Amazon QuickSight account.
15+
* This name is unique over all of Amazon Web Services, and it appears only when users sign in.
1616
* You can't change AccountName value after the Amazon QuickSight account is created.
1717
*/
1818
readonly accountName: string;
@@ -27,7 +27,7 @@ export interface QuickSightSubscriptionProps {
2727
* @default - ENTERPRISE is used as default.
2828
*/
2929
readonly edition: QuickSightEdition;
30-
30+
3131
/**
3232
* The Amazon Web Services account ID of the account that you're using to create your Amazon QuickSight account.
3333
*/
@@ -87,5 +87,5 @@ export enum QuickSightAuthenticationMethod {
8787
}
8888

8989
export enum QuickSightEdition {
90-
ENTERPRISE = 'ENTERPRISE',
90+
ENTERPRISE = 'ENTERPRISE',
9191
}

framework/src/consumption/lib/quicksight/quicksight-subscription.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
11
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
import { Context, TrackedConstruct, TrackedConstructProps } from "../../../utils";
5-
import { DsfProvider } from '../../../utils/lib/dsf-provider';
6-
import { QuickSightSubscriptionProps, QuickSightAuthenticationMethod } from './quicksight-subscription-props';
7-
import { Construct } from 'constructs';
84
import { CustomResource, Duration, RemovalPolicy } from 'aws-cdk-lib';
9-
import { IRole, PolicyDocument, Role , ServicePrincipal, PolicyStatement, Effect } from 'aws-cdk-lib/aws-iam';
10-
import { ILogGroup } from 'aws-cdk-lib/aws-logs';
5+
import { IRole, PolicyDocument, Role, ServicePrincipal, PolicyStatement, Effect } from 'aws-cdk-lib/aws-iam';
116
import { IFunction } from 'aws-cdk-lib/aws-lambda';
127
import { ILogGroup } from 'aws-cdk-lib/aws-logs';
138
import { Construct } from 'constructs';
14-
import { QuickSightSubscriptionProps } from './quicksight-subscription-props';
9+
import { QuickSightSubscriptionProps, QuickSightAuthenticationMethod } from './quicksight-subscription-props';
1510
import { Context, TrackedConstruct, TrackedConstructProps } from '../../../utils';
1611
import { DsfProvider } from '../../../utils/lib/dsf-provider';
1712

@@ -118,7 +113,7 @@ export class QuickSightSubscription extends TrackedConstruct {
118113
this.adminGroup = props.adminGroup;
119114
this.authorGroup = props.authorGroup;
120115
this.readerGroup = props.readerGroup;
121-
this.identityRegion = props.identityRegion;
116+
this.identityRegion = props.identityRegion;
122117

123118
this.policyActions = [
124119
'quicksight:Subscribe',
@@ -157,7 +152,7 @@ export class QuickSightSubscription extends TrackedConstruct {
157152
}
158153

159154
this.executionRole = new Role(this, 'Role', {
160-
assumedBy: new ServicePrincipal('lambda.amazonaws.com'),
155+
assumedBy: new ServicePrincipal('lambda.amazonaws.com'),
161156
inlinePolicies: {
162157
QuickSightSubscription: new PolicyDocument({
163158
statements: [
@@ -200,7 +195,7 @@ export class QuickSightSubscription extends TrackedConstruct {
200195
EDITION: props.edition,
201196
IDENTITY_REGION: props.identityRegion,
202197
},
203-
},
198+
},
204199
queryInterval: Duration.seconds(10),
205200
removalPolicy: this.removalPolicy,
206201
});

0 commit comments

Comments
 (0)