Add SqsListenerFilter for use by the annotation processor #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizzo
changed the title
There was a problem hiding this comment.
Thanks for the PR @erizzo!
Left a few comments, let me know what you think.
| @FunctionalInterface | ||
| public interface SqsListenerFilter { | ||
|
|
||
| boolean createEndpoint(SqsListener annotation); |
There was a problem hiding this comment.
Perhaps shouldCreateEndpoint?
| protected Endpoint createEndpoint(SqsListener sqsListenerAnnotation) { | ||
| if (filters.stream().anyMatch(f -> !f.createEndpoint(sqsListenerAnnotation))) { |
There was a problem hiding this comment.
I believe this logic would be better placed in the AbstractListenerAnnotationBeanPostProcessor, since it's not an SQS-specific logic.
| @@ -125,6 +126,7 @@ protected void detectAnnotationsAndRegisterEndpoints(Object bean, Class<?> targe | |||
| } | |||
| annotatedMethods.entrySet().stream() | |||
| .map(entry -> createAndConfigureEndpoint(bean, entry.getKey(), entry.getValue())) | |||
| .filter(Objects::nonNull) | |||
There was a problem hiding this comment.
Why not filter the endpoints here, before the map method?
|
@erizzo, we just merged a PR with a few changes to the annotation BPP, please rebase your branch and take a look at the changes. Thanks and looking forward to seeing this feature evolve! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
In a discussion about skipping certain
@SqsListenerannotation at runtime, it was suggested to provide a more convenient mechanism for applications. This is a suggested implementation of that idea.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps