Skip to content

fix: read max cells per chip in segment correctly #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

fix: read max cells per chip in segment correctly #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9200146
fix: read max cells per chip in segment correctly
yi-sun Feb 11, 2025
1c64210
chore: set jemalloc default
yi-sun Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reth-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ jobs:
- name: Set build args
id: set-build-args
run: |
FEATURES="bench-metrics,nightly-features,${{ inputs.memory_allocator || github.event.inputs.memory_allocator }}"
FEATURES="bench-metrics,nightly-features,${{ inputs.memory_allocator || github.event.inputs.memory_allocator || 'jemalloc' }}"
if [[ "${{ inputs.profiling || github.event.inputs.profiling }}" == "guest" ]]; then
OPTIONAL_ARGS="${OPTIONAL_ARGS} --profiling"
FEATURES="${FEATURES},profiling"
Expand Down
6 changes: 5 additions & 1 deletion bin/host/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ struct HostArgs {

#[clap(flatten)]
benchmark: BenchmarkCli,

/// Max cells per chip in segment for continuations
#[arg(short, long, alias = "max_cells_per_chip_in_segment")]
pub max_cells_per_chip_in_segment: Option<usize>,
}

const OPENVM_CLIENT_ETH_ELF: &[u8] = include_bytes!("../elf/openvm-client-eth");
Expand Down Expand Up @@ -181,7 +185,7 @@ async fn main() -> eyre::Result<()> {
let app_log_blowup = args.benchmark.app_log_blowup.unwrap_or(DEFAULT_APP_LOG_BLOWUP);
let max_segment_length = args.benchmark.max_segment_length.unwrap_or((1 << 23) - 100);
let max_cells_per_chip_in_segment =
args.benchmark.max_cells_per_chip_in_segment.unwrap_or(((1 << 23) - 100) * 120);
args.max_cells_per_chip_in_segment.unwrap_or(((1 << 23) - 100) * 120);

let vm_config =
reth_vm_config(app_log_blowup, max_segment_length, max_cells_per_chip_in_segment);
Expand Down
Loading