Open
Conversation
barbibulle
reviewed
Dec 26, 2016
Contributor
barbibulle
left a comment
barbibulle
left a comment
There was a problem hiding this comment.
The change for Ap4CommonEncryption.cpp is valid (ownership of the sample decrypter is transfered). But the change for Ap4SampleDescription isn't the right one. There was a bug, but this isn't the right fix (I am committing the fix soon: the m_AvccAtom should be part of the m_Details tree, which gets free'd when the object is deleted)
Contributor
Author
|
Cool -- just updated the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.