Install env scripts in receipts dir instead of bin dir#2423
Open
Gankra wants to merge 5 commits into
Open
Conversation
Contributor
ftr, we install Just to check, is this in response to a specific issue that someone ran into? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to address one of the original cardinal sins of cargo-dist: that in flat installs we create a sourceable script called
envin the bin dir, where it can shadow/usr/bin/env.This sin was originally forced by us not having any other directory we could put these files in, along with historical momentum of cargo calling the file
env.Since then we have introduced receipts, which means we have another dir where we can shove other random non-executable stuff.
envtoenv.shbecause come on it's a shell script by any other name, even though it's only eversourcedenv.shandenv.fishto the receipt direnvandenv.fishfiles from the bin dir, if they look like they were made by usAs always I am profoundly unconfident in my shell scripting (codex did most of it, but I don't even trust my reviews of shell code).