From 44b1ff9f785a439b6f2a096c648b16dc88406e0b Mon Sep 17 00:00:00 2001 From: SDKAuto Date: Tue, 13 May 2025 07:31:33 +0000 Subject: [PATCH] CodeGen from PR 34319 in Azure/azure-rest-api-specs Merge 168a6deff4b8237c0aa76b4ba408ee7b17995e41 into ba0c086df0ebe03a61579485c1c10de0d17804b2 --- .../Azure.ResourceManager.Advisor.net8.0.cs | 22 +------- ....ResourceManager.Advisor.netstandard2.0.cs | 22 +------- .../src/Generated/ArmAdvisorModelFactory.cs | 4 +- .../src/Generated/Models/Risk.cs | 54 ------------------- .../src/Generated/Models/ShortDescription.cs | 8 +-- ...rceRecommendationBaseData.Serialization.cs | 16 ------ .../ResourceRecommendationBaseData.cs | 6 +-- .../src/autorest.md | 2 +- .../Sample_SubscriptionResourceExtensions.cs | 4 +- sdk/storage/ci.yml | 2 + 10 files changed, 13 insertions(+), 127 deletions(-) delete mode 100644 sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/Models/Risk.cs diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/api/Azure.ResourceManager.Advisor.net8.0.cs b/sdk/advisor/Azure.ResourceManager.Advisor/api/Azure.ResourceManager.Advisor.net8.0.cs index 8e7a6a944a9b..7ae74ca798ad 100644 --- a/sdk/advisor/Azure.ResourceManager.Advisor/api/Azure.ResourceManager.Advisor.net8.0.cs +++ b/sdk/advisor/Azure.ResourceManager.Advisor/api/Azure.ResourceManager.Advisor.net8.0.cs @@ -110,7 +110,6 @@ public ResourceRecommendationBaseData() { } public string RecommendationTypeId { get { throw null; } set { } } public System.Collections.Generic.IDictionary Remediation { get { throw null; } } public Azure.ResourceManager.Advisor.Models.ResourceMetadata ResourceMetadata { get { throw null; } set { } } - public Azure.ResourceManager.Advisor.Models.Risk? Risk { get { throw null; } set { } } public Azure.ResourceManager.Advisor.Models.ShortDescription ShortDescription { get { throw null; } set { } } public System.Collections.Generic.IList SuppressionIds { get { throw null; } } protected override void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { } @@ -232,7 +231,7 @@ public static partial class ArmAdvisorModelFactory public static Azure.ResourceManager.Advisor.Models.ConfigData ConfigData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, bool? exclude = default(bool?), Azure.ResourceManager.Advisor.Models.CpuThreshold? lowCpuThreshold = default(Azure.ResourceManager.Advisor.Models.CpuThreshold?), System.Collections.Generic.IEnumerable digests = null) { throw null; } public static Azure.ResourceManager.Advisor.MetadataEntityData MetadataEntityData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, string displayName = null, System.Collections.Generic.IEnumerable dependsOn = null, System.Collections.Generic.IEnumerable applicableScenarios = null, System.Collections.Generic.IEnumerable supportedValues = null) { throw null; } public static Azure.ResourceManager.Advisor.Models.MetadataSupportedValueDetail MetadataSupportedValueDetail(string id = null, string displayName = null) { throw null; } - public static Azure.ResourceManager.Advisor.ResourceRecommendationBaseData ResourceRecommendationBaseData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, Azure.ResourceManager.Advisor.Models.Category? category = default(Azure.ResourceManager.Advisor.Models.Category?), Azure.ResourceManager.Advisor.Models.Impact? impact = default(Azure.ResourceManager.Advisor.Models.Impact?), string impactedField = null, string impactedValue = null, System.DateTimeOffset? lastUpdated = default(System.DateTimeOffset?), System.Collections.Generic.IDictionary metadata = null, string recommendationTypeId = null, Azure.ResourceManager.Advisor.Models.Risk? risk = default(Azure.ResourceManager.Advisor.Models.Risk?), Azure.ResourceManager.Advisor.Models.ShortDescription shortDescription = null, System.Collections.Generic.IEnumerable suppressionIds = null, System.Collections.Generic.IDictionary extendedProperties = null, Azure.ResourceManager.Advisor.Models.ResourceMetadata resourceMetadata = null, string description = null, string label = null, string learnMoreLink = null, string potentialBenefits = null, System.Collections.Generic.IEnumerable> actions = null, System.Collections.Generic.IDictionary remediation = null, System.Collections.Generic.IDictionary exposedMetadataProperties = null) { throw null; } + public static Azure.ResourceManager.Advisor.ResourceRecommendationBaseData ResourceRecommendationBaseData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, Azure.ResourceManager.Advisor.Models.Category? category = default(Azure.ResourceManager.Advisor.Models.Category?), Azure.ResourceManager.Advisor.Models.Impact? impact = default(Azure.ResourceManager.Advisor.Models.Impact?), string impactedField = null, string impactedValue = null, System.DateTimeOffset? lastUpdated = default(System.DateTimeOffset?), System.Collections.Generic.IDictionary metadata = null, string recommendationTypeId = null, Azure.ResourceManager.Advisor.Models.ShortDescription shortDescription = null, System.Collections.Generic.IEnumerable suppressionIds = null, System.Collections.Generic.IDictionary extendedProperties = null, Azure.ResourceManager.Advisor.Models.ResourceMetadata resourceMetadata = null, string description = null, string label = null, string learnMoreLink = null, string potentialBenefits = null, System.Collections.Generic.IEnumerable> actions = null, System.Collections.Generic.IDictionary remediation = null, System.Collections.Generic.IDictionary exposedMetadataProperties = null) { throw null; } public static Azure.ResourceManager.Advisor.SuppressionContractData SuppressionContractData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, string suppressionId = null, string ttl = null, System.DateTimeOffset? expirationTimeStamp = default(System.DateTimeOffset?)) { throw null; } } [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] @@ -387,25 +386,6 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer System.BinaryData System.ClientModel.Primitives.IPersistableModel.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } } [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] - public readonly partial struct Risk : System.IEquatable - { - private readonly object _dummy; - private readonly int _dummyPrimitive; - public Risk(string value) { throw null; } - public static Azure.ResourceManager.Advisor.Models.Risk Error { get { throw null; } } - public static Azure.ResourceManager.Advisor.Models.Risk None { get { throw null; } } - public static Azure.ResourceManager.Advisor.Models.Risk Warning { get { throw null; } } - public bool Equals(Azure.ResourceManager.Advisor.Models.Risk other) { throw null; } - [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)] - public override bool Equals(object obj) { throw null; } - [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)] - public override int GetHashCode() { throw null; } - public static bool operator ==(Azure.ResourceManager.Advisor.Models.Risk left, Azure.ResourceManager.Advisor.Models.Risk right) { throw null; } - public static implicit operator Azure.ResourceManager.Advisor.Models.Risk (string value) { throw null; } - public static bool operator !=(Azure.ResourceManager.Advisor.Models.Risk left, Azure.ResourceManager.Advisor.Models.Risk right) { throw null; } - public override string ToString() { throw null; } - } - [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] public readonly partial struct Scenario : System.IEquatable { private readonly object _dummy; diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/api/Azure.ResourceManager.Advisor.netstandard2.0.cs b/sdk/advisor/Azure.ResourceManager.Advisor/api/Azure.ResourceManager.Advisor.netstandard2.0.cs index 8e7a6a944a9b..7ae74ca798ad 100644 --- a/sdk/advisor/Azure.ResourceManager.Advisor/api/Azure.ResourceManager.Advisor.netstandard2.0.cs +++ b/sdk/advisor/Azure.ResourceManager.Advisor/api/Azure.ResourceManager.Advisor.netstandard2.0.cs @@ -110,7 +110,6 @@ public ResourceRecommendationBaseData() { } public string RecommendationTypeId { get { throw null; } set { } } public System.Collections.Generic.IDictionary Remediation { get { throw null; } } public Azure.ResourceManager.Advisor.Models.ResourceMetadata ResourceMetadata { get { throw null; } set { } } - public Azure.ResourceManager.Advisor.Models.Risk? Risk { get { throw null; } set { } } public Azure.ResourceManager.Advisor.Models.ShortDescription ShortDescription { get { throw null; } set { } } public System.Collections.Generic.IList SuppressionIds { get { throw null; } } protected override void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { } @@ -232,7 +231,7 @@ public static partial class ArmAdvisorModelFactory public static Azure.ResourceManager.Advisor.Models.ConfigData ConfigData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, bool? exclude = default(bool?), Azure.ResourceManager.Advisor.Models.CpuThreshold? lowCpuThreshold = default(Azure.ResourceManager.Advisor.Models.CpuThreshold?), System.Collections.Generic.IEnumerable digests = null) { throw null; } public static Azure.ResourceManager.Advisor.MetadataEntityData MetadataEntityData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, string displayName = null, System.Collections.Generic.IEnumerable dependsOn = null, System.Collections.Generic.IEnumerable applicableScenarios = null, System.Collections.Generic.IEnumerable supportedValues = null) { throw null; } public static Azure.ResourceManager.Advisor.Models.MetadataSupportedValueDetail MetadataSupportedValueDetail(string id = null, string displayName = null) { throw null; } - public static Azure.ResourceManager.Advisor.ResourceRecommendationBaseData ResourceRecommendationBaseData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, Azure.ResourceManager.Advisor.Models.Category? category = default(Azure.ResourceManager.Advisor.Models.Category?), Azure.ResourceManager.Advisor.Models.Impact? impact = default(Azure.ResourceManager.Advisor.Models.Impact?), string impactedField = null, string impactedValue = null, System.DateTimeOffset? lastUpdated = default(System.DateTimeOffset?), System.Collections.Generic.IDictionary metadata = null, string recommendationTypeId = null, Azure.ResourceManager.Advisor.Models.Risk? risk = default(Azure.ResourceManager.Advisor.Models.Risk?), Azure.ResourceManager.Advisor.Models.ShortDescription shortDescription = null, System.Collections.Generic.IEnumerable suppressionIds = null, System.Collections.Generic.IDictionary extendedProperties = null, Azure.ResourceManager.Advisor.Models.ResourceMetadata resourceMetadata = null, string description = null, string label = null, string learnMoreLink = null, string potentialBenefits = null, System.Collections.Generic.IEnumerable> actions = null, System.Collections.Generic.IDictionary remediation = null, System.Collections.Generic.IDictionary exposedMetadataProperties = null) { throw null; } + public static Azure.ResourceManager.Advisor.ResourceRecommendationBaseData ResourceRecommendationBaseData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, Azure.ResourceManager.Advisor.Models.Category? category = default(Azure.ResourceManager.Advisor.Models.Category?), Azure.ResourceManager.Advisor.Models.Impact? impact = default(Azure.ResourceManager.Advisor.Models.Impact?), string impactedField = null, string impactedValue = null, System.DateTimeOffset? lastUpdated = default(System.DateTimeOffset?), System.Collections.Generic.IDictionary metadata = null, string recommendationTypeId = null, Azure.ResourceManager.Advisor.Models.ShortDescription shortDescription = null, System.Collections.Generic.IEnumerable suppressionIds = null, System.Collections.Generic.IDictionary extendedProperties = null, Azure.ResourceManager.Advisor.Models.ResourceMetadata resourceMetadata = null, string description = null, string label = null, string learnMoreLink = null, string potentialBenefits = null, System.Collections.Generic.IEnumerable> actions = null, System.Collections.Generic.IDictionary remediation = null, System.Collections.Generic.IDictionary exposedMetadataProperties = null) { throw null; } public static Azure.ResourceManager.Advisor.SuppressionContractData SuppressionContractData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, string suppressionId = null, string ttl = null, System.DateTimeOffset? expirationTimeStamp = default(System.DateTimeOffset?)) { throw null; } } [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] @@ -387,25 +386,6 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer System.BinaryData System.ClientModel.Primitives.IPersistableModel.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } } [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] - public readonly partial struct Risk : System.IEquatable - { - private readonly object _dummy; - private readonly int _dummyPrimitive; - public Risk(string value) { throw null; } - public static Azure.ResourceManager.Advisor.Models.Risk Error { get { throw null; } } - public static Azure.ResourceManager.Advisor.Models.Risk None { get { throw null; } } - public static Azure.ResourceManager.Advisor.Models.Risk Warning { get { throw null; } } - public bool Equals(Azure.ResourceManager.Advisor.Models.Risk other) { throw null; } - [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)] - public override bool Equals(object obj) { throw null; } - [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)] - public override int GetHashCode() { throw null; } - public static bool operator ==(Azure.ResourceManager.Advisor.Models.Risk left, Azure.ResourceManager.Advisor.Models.Risk right) { throw null; } - public static implicit operator Azure.ResourceManager.Advisor.Models.Risk (string value) { throw null; } - public static bool operator !=(Azure.ResourceManager.Advisor.Models.Risk left, Azure.ResourceManager.Advisor.Models.Risk right) { throw null; } - public override string ToString() { throw null; } - } - [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] public readonly partial struct Scenario : System.IEquatable { private readonly object _dummy; diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ArmAdvisorModelFactory.cs b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ArmAdvisorModelFactory.cs index 5289cf7f2f37..ccf0a3e8e384 100644 --- a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ArmAdvisorModelFactory.cs +++ b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ArmAdvisorModelFactory.cs @@ -89,7 +89,6 @@ public static ConfigData ConfigData(ResourceIdentifier id = null, string name = /// The most recent time that Advisor checked the validity of the recommendation. /// The recommendation metadata. /// The recommendation-type GUID. - /// The potential risk of not implementing the recommendation. /// A summary of the recommendation. /// The list of snoozed and dismissed rules for the recommendation. /// Extended properties. @@ -102,7 +101,7 @@ public static ConfigData ConfigData(ResourceIdentifier id = null, string name = /// The automated way to apply recommendation. /// The recommendation metadata properties exposed to customer to provide additional information. /// A new instance for mocking. - public static ResourceRecommendationBaseData ResourceRecommendationBaseData(ResourceIdentifier id = null, string name = null, ResourceType resourceType = default, SystemData systemData = null, Category? category = null, Impact? impact = null, string impactedField = null, string impactedValue = null, DateTimeOffset? lastUpdated = null, IDictionary metadata = null, string recommendationTypeId = null, Risk? risk = null, ShortDescription shortDescription = null, IEnumerable suppressionIds = null, IDictionary extendedProperties = null, ResourceMetadata resourceMetadata = null, string description = null, string label = null, string learnMoreLink = null, string potentialBenefits = null, IEnumerable> actions = null, IDictionary remediation = null, IDictionary exposedMetadataProperties = null) + public static ResourceRecommendationBaseData ResourceRecommendationBaseData(ResourceIdentifier id = null, string name = null, ResourceType resourceType = default, SystemData systemData = null, Category? category = null, Impact? impact = null, string impactedField = null, string impactedValue = null, DateTimeOffset? lastUpdated = null, IDictionary metadata = null, string recommendationTypeId = null, ShortDescription shortDescription = null, IEnumerable suppressionIds = null, IDictionary extendedProperties = null, ResourceMetadata resourceMetadata = null, string description = null, string label = null, string learnMoreLink = null, string potentialBenefits = null, IEnumerable> actions = null, IDictionary remediation = null, IDictionary exposedMetadataProperties = null) { metadata ??= new Dictionary(); suppressionIds ??= new List(); @@ -123,7 +122,6 @@ public static ResourceRecommendationBaseData ResourceRecommendationBaseData(Reso lastUpdated, metadata, recommendationTypeId, - risk, shortDescription, suppressionIds?.ToList(), extendedProperties, diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/Models/Risk.cs b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/Models/Risk.cs deleted file mode 100644 index 0e31a7046481..000000000000 --- a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/Models/Risk.cs +++ /dev/null @@ -1,54 +0,0 @@ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. - -// - -#nullable disable - -using System; -using System.ComponentModel; - -namespace Azure.ResourceManager.Advisor.Models -{ - /// The potential risk of not implementing the recommendation. - public readonly partial struct Risk : IEquatable - { - private readonly string _value; - - /// Initializes a new instance of . - /// is null. - public Risk(string value) - { - _value = value ?? throw new ArgumentNullException(nameof(value)); - } - - private const string ErrorValue = "Error"; - private const string WarningValue = "Warning"; - private const string NoneValue = "None"; - - /// Error. - public static Risk Error { get; } = new Risk(ErrorValue); - /// Warning. - public static Risk Warning { get; } = new Risk(WarningValue); - /// None. - public static Risk None { get; } = new Risk(NoneValue); - /// Determines if two values are the same. - public static bool operator ==(Risk left, Risk right) => left.Equals(right); - /// Determines if two values are not the same. - public static bool operator !=(Risk left, Risk right) => !left.Equals(right); - /// Converts a to a . - public static implicit operator Risk(string value) => new Risk(value); - - /// - [EditorBrowsable(EditorBrowsableState.Never)] - public override bool Equals(object obj) => obj is Risk other && Equals(other); - /// - public bool Equals(Risk other) => string.Equals(_value, other._value, StringComparison.InvariantCultureIgnoreCase); - - /// - [EditorBrowsable(EditorBrowsableState.Never)] - public override int GetHashCode() => _value != null ? StringComparer.InvariantCultureIgnoreCase.GetHashCode(_value) : 0; - /// - public override string ToString() => _value; - } -} diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/Models/ShortDescription.cs b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/Models/ShortDescription.cs index e3010e7a4c17..8b97b01de299 100644 --- a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/Models/ShortDescription.cs +++ b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/Models/ShortDescription.cs @@ -51,8 +51,8 @@ public ShortDescription() } /// Initializes a new instance of . - /// The issue or opportunity identified by the recommendation. - /// The remediation action suggested by the recommendation. + /// The issue or opportunity identified by the recommendation and proposed solution. + /// The issue or opportunity identified by the recommendation and proposed solution. /// Keeps track of any properties unknown to the library. internal ShortDescription(string problem, string solution, IDictionary serializedAdditionalRawData) { @@ -61,9 +61,9 @@ internal ShortDescription(string problem, string solution, IDictionary The issue or opportunity identified by the recommendation. + /// The issue or opportunity identified by the recommendation and proposed solution. public string Problem { get; set; } - /// The remediation action suggested by the recommendation. + /// The issue or opportunity identified by the recommendation and proposed solution. public string Solution { get; set; } } } diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ResourceRecommendationBaseData.Serialization.cs b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ResourceRecommendationBaseData.Serialization.cs index 3b2d9856e0d1..7a5ada154997 100644 --- a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ResourceRecommendationBaseData.Serialization.cs +++ b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ResourceRecommendationBaseData.Serialization.cs @@ -92,11 +92,6 @@ protected override void JsonModelWriteCore(Utf8JsonWriter writer, ModelReaderWri writer.WritePropertyName("recommendationTypeId"u8); writer.WriteStringValue(RecommendationTypeId); } - if (Optional.IsDefined(Risk)) - { - writer.WritePropertyName("risk"u8); - writer.WriteStringValue(Risk.Value.ToString()); - } if (Optional.IsDefined(ShortDescription)) { writer.WritePropertyName("shortDescription"u8); @@ -261,7 +256,6 @@ internal static ResourceRecommendationBaseData DeserializeResourceRecommendation DateTimeOffset? lastUpdated = default; IDictionary metadata = default; string recommendationTypeId = default; - Risk? risk = default; ShortDescription shortDescription = default; IList suppressionIds = default; IDictionary extendedProperties = default; @@ -373,15 +367,6 @@ internal static ResourceRecommendationBaseData DeserializeResourceRecommendation recommendationTypeId = property0.Value.GetString(); continue; } - if (property0.NameEquals("risk"u8)) - { - if (property0.Value.ValueKind == JsonValueKind.Null) - { - continue; - } - risk = new Risk(property0.Value.GetString()); - continue; - } if (property0.NameEquals("shortDescription"u8)) { if (property0.Value.ValueKind == JsonValueKind.Null) @@ -544,7 +529,6 @@ internal static ResourceRecommendationBaseData DeserializeResourceRecommendation lastUpdated, metadata ?? new ChangeTrackingDictionary(), recommendationTypeId, - risk, shortDescription, suppressionIds ?? new ChangeTrackingList(), extendedProperties ?? new ChangeTrackingDictionary(), diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ResourceRecommendationBaseData.cs b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ResourceRecommendationBaseData.cs index 6f972e501ff9..fba25edb10ee 100644 --- a/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ResourceRecommendationBaseData.cs +++ b/sdk/advisor/Azure.ResourceManager.Advisor/src/Generated/ResourceRecommendationBaseData.cs @@ -74,7 +74,6 @@ public ResourceRecommendationBaseData() /// The most recent time that Advisor checked the validity of the recommendation. /// The recommendation metadata. /// The recommendation-type GUID. - /// The potential risk of not implementing the recommendation. /// A summary of the recommendation. /// The list of snoozed and dismissed rules for the recommendation. /// Extended properties. @@ -87,7 +86,7 @@ public ResourceRecommendationBaseData() /// The automated way to apply recommendation. /// The recommendation metadata properties exposed to customer to provide additional information. /// Keeps track of any properties unknown to the library. - internal ResourceRecommendationBaseData(ResourceIdentifier id, string name, ResourceType resourceType, SystemData systemData, Category? category, Impact? impact, string impactedField, string impactedValue, DateTimeOffset? lastUpdated, IDictionary metadata, string recommendationTypeId, Risk? risk, ShortDescription shortDescription, IList suppressionIds, IDictionary extendedProperties, ResourceMetadata resourceMetadata, string description, string label, string learnMoreLink, string potentialBenefits, IList> actions, IDictionary remediation, IDictionary exposedMetadataProperties, IDictionary serializedAdditionalRawData) : base(id, name, resourceType, systemData) + internal ResourceRecommendationBaseData(ResourceIdentifier id, string name, ResourceType resourceType, SystemData systemData, Category? category, Impact? impact, string impactedField, string impactedValue, DateTimeOffset? lastUpdated, IDictionary metadata, string recommendationTypeId, ShortDescription shortDescription, IList suppressionIds, IDictionary extendedProperties, ResourceMetadata resourceMetadata, string description, string label, string learnMoreLink, string potentialBenefits, IList> actions, IDictionary remediation, IDictionary exposedMetadataProperties, IDictionary serializedAdditionalRawData) : base(id, name, resourceType, systemData) { Category = category; Impact = impact; @@ -96,7 +95,6 @@ internal ResourceRecommendationBaseData(ResourceIdentifier id, string name, Reso LastUpdated = lastUpdated; Metadata = metadata; RecommendationTypeId = recommendationTypeId; - Risk = risk; ShortDescription = shortDescription; SuppressionIds = suppressionIds; ExtendedProperties = extendedProperties; @@ -154,8 +152,6 @@ internal ResourceRecommendationBaseData(ResourceIdentifier id, string name, Reso public IDictionary Metadata { get; } /// The recommendation-type GUID. public string RecommendationTypeId { get; set; } - /// The potential risk of not implementing the recommendation. - public Risk? Risk { get; set; } /// A summary of the recommendation. public ShortDescription ShortDescription { get; set; } /// The list of snoozed and dismissed rules for the recommendation. diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/src/autorest.md b/sdk/advisor/Azure.ResourceManager.Advisor/src/autorest.md index 44168de5e8ed..d043a974a281 100644 --- a/sdk/advisor/Azure.ResourceManager.Advisor/src/autorest.md +++ b/sdk/advisor/Azure.ResourceManager.Advisor/src/autorest.md @@ -8,7 +8,7 @@ azure-arm: true csharp: true library-name: Advisor namespace: Azure.ResourceManager.Advisor -require: https://github.com/Azure/azure-rest-api-specs/blob/db6d33733cd1eb939b863a6cdbcb9de12ac002e1/specification/advisor/resource-manager/readme.md +require: /mnt/vss/_work/1/s/azure-rest-api-specs/specification/advisor/resource-manager/readme.md tag: package-2020-01 output-folder: $(this-folder)/Generated clear-output-folder: true diff --git a/sdk/advisor/Azure.ResourceManager.Advisor/tests/Generated/Samples/Sample_SubscriptionResourceExtensions.cs b/sdk/advisor/Azure.ResourceManager.Advisor/tests/Generated/Samples/Sample_SubscriptionResourceExtensions.cs index b5a0c01b288b..3cb1c12d57a4 100644 --- a/sdk/advisor/Azure.ResourceManager.Advisor/tests/Generated/Samples/Sample_SubscriptionResourceExtensions.cs +++ b/sdk/advisor/Azure.ResourceManager.Advisor/tests/Generated/Samples/Sample_SubscriptionResourceExtensions.cs @@ -121,12 +121,12 @@ public async Task GetGenerateStatusRecommendation_GetGenerateStatus() // this example assumes you already have this SubscriptionResource created on azure // for more information of creating SubscriptionResource, please refer to the document of SubscriptionResource - string subscriptionId = "subscriptionId"; + string subscriptionId = "00000000-0000-0000-0000-000000000000"; ResourceIdentifier subscriptionResourceId = SubscriptionResource.CreateResourceIdentifier(subscriptionId); SubscriptionResource subscriptionResource = client.GetSubscriptionResource(subscriptionResourceId); // invoke the operation - Guid operationId = Guid.Parse("operationGUID"); + Guid operationId = Guid.Parse("00000000-0000-0000-0000-000000000000"); await subscriptionResource.GetGenerateStatusRecommendationAsync(operationId); Console.WriteLine("Succeeded"); diff --git a/sdk/storage/ci.yml b/sdk/storage/ci.yml index 2ca0501b60bd..4e749e6b85b1 100644 --- a/sdk/storage/ci.yml +++ b/sdk/storage/ci.yml @@ -12,6 +12,8 @@ trigger: - sdk/storage/Azure.Storage.DataMovement/ - sdk/storage/Azure.Storage.DataMovement.Blobs/ - sdk/storage/Azure.Storage.DataMovement.Files/ + exclude: + - sdk/storage/Azure.ResourceManager.Storage/ - sdk/storage/Azure.Storage.DataMovement.Blobs.Files.Shares/ exclude: - sdk/storage/Azure.ResourceManager.Storage/