chore: move goreleaser job to release workflow #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiquanghiep
force-pushed
the
hiep-fix-release-event
branch
from
3050b9e to
9e328e1
Compare
filippos47
approved these changes
May 7, 2025
|
@filippos47 Yes I do think we need it. gorelease is still needed in case we create the release without using the workflow |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
KonradStaniec
pushed a commit
that referenced
this pull request
May 12, 2025
KonradStaniec
pushed a commit
that referenced
this pull request
May 12, 2025
maiquanghiep
added a commit
that referenced
this pull request
May 12, 2025
maiquanghiep
added a commit
that referenced
this pull request
May 12, 2025
RafilxTenfen
pushed a commit
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a release is created using the release workflow, it doesn't trigger the gorelease workflow due to the limitation with
github.token(ref).This PR moves the goreleaser job into the release workflow, allowing it to be executed once the release is created