PR fixes

Author: Bartosz Litwiniuk

Runtime/Model/BacktraceUnhandledException.cs

@@ -137,8 +137,8 @@ private List<BacktraceStackFrame> ConvertStackFrames(IEnumerable<string> frames)
                 }
 
                 // we require a '(' that appears before this ')'
-                int openParenIndex = frameString.LastIndexOf('(', methodNameEndIndex);
-                if (openParenIndex == -1 || openParenIndex > methodNameEndIndex)
+                int openParentIndex = frameString.LastIndexOf('(', methodNameEndIndex);
+                if (openParentIndex == -1 || openParentIndex > methodNameEndIndex)
                 {
                     // invalid shape: no matching '(' before ')'
                     result.Add(new BacktraceStackFrame { FunctionName = frame });
@@ -282,8 +282,6 @@ private BacktraceStackFrame SetNativeStackTraceInformation(string frameString)
             var stackFrame = new BacktraceStackFrame
             {
                 StackFrameType = Types.BacktraceStackFrameType.Native,
-                FunctionName = string.Empty,
-                Line = 0
             };
 
             if (string.IsNullOrEmpty(frameString))

Tests/Runtime/NativeParserTests.cs

@@ -0,0 +1,44 @@
+using Backtrace.Unity.Model;
+using NUnit.Framework;
+using System.Reflection;
+
+namespace Backtrace.Unity.Tests.Runtime
+{
+    public class NativeStackTraceParser
+    {
+        private static BacktraceStackFrame Parse(string frame)
+        {
+            var instance = new BacktraceUnhandledException("msg", "");
+            var methodInfo = typeof(BacktraceUnhandledException)
+                .GetMethod("SetNativeStackTraceInformation",
+                    BindingFlags.NonPublic | BindingFlags.Instance);
+            Assert.IsNotNull(methodInfo);
+            return (BacktraceStackFrame)methodInfo.Invoke(instance, new object[] { frame });
+        }
+
+        [Test]
+        public void SymbolLessModuleLine_ParsesAddressAndLibrary_NoThrow()
+        {
+            var backtraceStackFrame = Parse("0x00007ffad7723088 (UnityPlayer)");
+            Assert.AreEqual("0x00007ffad7723088", backtraceStackFrame.Address);
+            Assert.AreEqual("UnityPlayer", backtraceStackFrame.Library);
+            Assert.AreEqual(string.Empty, backtraceStackFrame.FunctionName);
+            Assert.AreEqual(Types.BacktraceStackFrameType.Native, backtraceStackFrame.StackFrameType);
+        }
+
+        [Test]
+        public void WithSymbol_ParsesMethod()
+        {
+            var backtraceStackFrame = Parse("0x00007ffad7ee3c7d (UnityPlayer) UnityMain");
+            Assert.AreEqual("UnityPlayer", backtraceStackFrame.Library);
+            Assert.AreEqual("UnityMain", backtraceStackFrame.FunctionName);
+        }
+
+        [Test]
+        public void UnknownShape_ReturnsRawInFunctionName()
+        {
+            var backtraceStackFrame = Parse("nonsense frame with no address");
+            Assert.AreEqual("nonsense frame with no address", backtraceStackFrame.FunctionName);
+        }
+    }
+}