Skip to content

Update AutoComplete.php to support PHP 8 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update AutoComplete.php to support PHP 8 #135

wants to merge 2 commits into from

Conversation

martindrapeau
Copy link

Removed default argument not allowed by PHP 8.

Merge this along with nafiesl's PR #130.

nafiesl
nafiesl approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@nafiesl nafiesl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can close my PR #130 if this one gets merged. This PR adds support for PHP 8.x as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nafiesl nafiesl nafiesl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martindrapeau @nafiesl