Skip to content

fix Overview on dark bg#1121

Open
nim65s wants to merge 1 commit into
snapcast:masterfrom
nim65s:master
Open

fix Overview on dark bg#1121
nim65s wants to merge 1 commit into
snapcast:masterfrom
nim65s:master

Conversation

@nim65s
Copy link
Copy Markdown

@nim65s nim65s commented Apr 12, 2023

Hi,

When github is set on the dark theme, the Overview fig on the README is impossible to read:

dark

A quick fix is to add some colored rectangles behind the black text on transparent background.

@badaix
Copy link
Copy Markdown
Member

badaix commented Jul 14, 2023

Thanks, I think the clean solution is to use two different images, one for light and one for dark mode, as described here:
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to

@nim65s
Copy link
Copy Markdown
Author

nim65s commented Jul 15, 2023

Sure, this could be a better solution than the quickfix I made. But I have no idea how to choose the colors. Here is a render of my solution, for reference.
overview

What would you change for the dark mode ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants