dynamic buffer pool, used for server TCP for the moment#1438
Closed
aanno wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Closed in favour of #1484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some profiling on snapcast (while working on #1423). From my measurements, I concluded that a dynamic buffer pool for audio data would increase the performance.
Hence this is such a dynamic buffer pool. It is at
common/buffer_pool.*that makes it possible to use it in server and client. However, this PR only uses it for TCP in the server (for shared_const_buffer). But I guess it could be used in the client for for WS as well.Pull Request Checklist
Contributions must be licensed under the GPL-3.0 License
This project loosely follows the Google C++ Style Guide
For better compatibility with embedded toolchains, the used C++ standard should be limited to C++17
Code should be formatted by running
make reformatBranch from the
developbranch and ensure it is up to date with the currentdevelopbranch before submitting your pull request. If it doesn't merge cleanly withdevelop, you may be asked to resolve the conflicts. Pull requests to master will be closed.Commits should be as small as possible while ensuring that each commit is correct independently (i.e., each commit should compile and pass tests).
Pull requests must not contain compiled sources (already set by the default .gitignore) or binary files
Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests. If tested manually, provide information about the test scope in the PR description (e.g. “Test passed: Upgrade version from 0.42 to 0.42.23.”).
Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
If your patch is not getting reviewed or you need a specific person to review it, you can @-reply a reviewer asking for a review in the pull request or a comment, or you can ask for a review by contacting us via email.
Post review: