Skip to content

Conversation

mkflow27
Copy link
Contributor

@mkflow27 mkflow27 commented Sep 16, 2025

Fixes #717 &

  • test/validateNewChainSetup.test.ts - Refactored to use warnings instead of failures so that ci passes whenever a new chain is rolled out

@mkflow27 mkflow27 marked this pull request as ready for review September 17, 2025 16:17
@MattPereira
Copy link
Member

MattPereira commented Sep 17, 2025

i guess i dont mind supported network test failing cus new chain deployments will be infrequent, but is a tiny bit more work for PR reviewers to realize that 😂

@brunoguerios wydt?

@MattPereira
Copy link
Member

MattPereira commented Sep 17, 2025

wait also im having to modify the pnpm-workspace.yaml in order to install packages or run tests locally. is this just a my machine environment thing?

image

@brunoguerios
Copy link
Member

i guess i dont mind supported network test failing cus new chain deployments will be infrequent, but is a tiny bit more work for PR reviewers to realize that 😂

@brunoguerios wydt?

I'm actually wondering if we need that check at all 😬
If we do keep it, CI will bump into this "unrelated issue" whenever there's parallel work happening while launching on a new chain.
I think we need to make sure that the SDK is properly setup for all chains it supports, but not necessarily in sync with the API, right?
If you think it's ok to leave as is, I'd say we should skip the failing test temporarily until the new chain is properly supported by the SDK as well.

@MattPereira
Copy link
Member

@brunoguerios ya i agree prolly best to just remove the test since seem safe to assume we will always be notified when we need to add a new network to SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add LBP HyperEVM addresses

3 participants