Skip to content

Conversation

bulkcade
Copy link
Contributor

@bulkcade bulkcade commented Apr 11, 2025

Description

Please include a summary of the change and if relevant which issue is fixed. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas

@bulkcade bulkcade requested a review from mendesfabio as a code owner April 11, 2025 09:23
"internalType": "uint16",
"name": "updateInterval",
"type": "uint16"
"type": "uint40",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to factory input struct that was passing in uint16 instead of uint40. It is uint40 instead of uint64 so there is no issue with the update weight runner that deals in uint40s

},
{
"name": "updateInterval",
"type": "uint40",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to factory input struct. Reason for update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant