Fix memory leak during vertex picking in mesh viewer

Max · baldurk · commit 95fd419d66f0 · 2026-02-03T20:49:04.000+09:00
Deallocate temporary memory for vertex indices,
referenced by raw pointer
diff --git a/renderdoc/driver/gl/gl_debug.cpp b/renderdoc/driver/gl/gl_debug.cpp
@@ -2794,6 +2794,8 @@ uint32_t GLReplay::PickVertex(uint32_t eventId, int32_t width, int32_t height,
 
     drv.glBindBuffer(eGL_SHADER_STORAGE_BUFFER, DebugData.pickIBBuf);
     drv.glBufferSubData(eGL_SHADER_STORAGE_BUFFER, 0, numIndices * sizeof(uint32_t), outidxs.data());
+
+    delete[] idxs;
   }
 
   // unpack and linearise the data

Original file line number	Diff line number	Diff line change
`@@ -2794,6 +2794,8 @@ uint32_t GLReplay::PickVertex(uint32_t eventId, int32_t width, int32_t height,`
`2794`	`2794`
`2795`	`2795`	`drv.glBindBuffer(eGL_SHADER_STORAGE_BUFFER, DebugData.pickIBBuf);`
`2796`	`2796`	`drv.glBufferSubData(eGL_SHADER_STORAGE_BUFFER, 0, numIndices * sizeof(uint32_t), outidxs.data());`
	`2797`	`+`
	`2798`	`+ delete[] idxs;`
`2797`	`2799`	`}`
`2798`	`2800`
`2799`	`2801`	`// unpack and linearise the data`