Pick up updates to syntax highlighting themes from shiki

- New location for list of themes
- Add support for 3-digit hex colors
- Use better default theme for github-dark-dim and solarized-light

Author: banga

README.md

@@ -71,7 +71,7 @@ Syntax highlighting is supported via [shiki](https://github.com/shikijs/shiki/),
 git config split-diffs.syntax-highlighting-theme <name>
 ```
 
-The supported syntax highlighting themes are listed at https://github.com/shikijs/shiki/blob/v0.9.3/docs/themes.md
+The supported syntax highlighting themes are listed at https://github.com/shikijs/textmate-grammars-themes/tree/main/packages/tm-themes#tm-themes
 
 You can disable syntax highlighting by setting the name to empty:
 
@@ -175,11 +175,11 @@ git config split-diffs.theme-name monochrome-light
 
 Tested by measuring the time it took to pipe the output `git log -p` to `/dev/null` via `git-split-diffs` with the default theme:
 
-| Features enabled                                      | ms/kloc         |
-| ----------------------------------------------------- | --------------- |
-| Everything                                            | 45              |
-| No syntax highlighting                                | 15              |
-| No syntax highlighting, no inline change highlighting | 13              |
+| Features enabled                                      | ms/kloc |
+| ----------------------------------------------------- | ------- |
+| Everything                                            | 45      |
+| No syntax highlighting                                | 15      |
+| No syntax highlighting, no inline change highlighting | 13      |
 
 ## Troubleshooting
 

screenshots/github-dark-dim.png

@@ -77,21 +77,24 @@ export type ThemeColor = {
  * The hex string is of the format #rrggbb(aa)
  */
 function hexToRgba(hex: string): ColorRgba {
-    assert.ok(hex.length === 7 || hex.length === 9);
+    assert.ok(hex.length === 7 || hex.length === 9 || hex.length === 4, hex);
 
-    let hexNo = parseInt(hex.slice(1), 16);
+    hex = hex.slice(1);
+
+    let hexNo = parseInt(hex, 16);
+    let bits = hex.length === 3 ? 4 : 8;
 
     let a = 255;
-    if (hex.length === 9) {
+    if (hex.length === 8) {
         a = hexNo & 0xff;
-        hexNo >>>= 8;
+        hexNo >>>= bits;
     }
 
     const b = hexNo & 0xff;
-    hexNo >>>= 8;
+    hexNo >>>= bits;
 
     const g = hexNo & 0xff;
-    hexNo >>>= 8;
+    hexNo >>>= bits;
 
     const r = hexNo & 0xff;
 

screenshots/solarized-light.png

@@ -1,5 +1,5 @@
 {
-    "SYNTAX_HIGHLIGHTING_THEME": "github-dark",
+    "SYNTAX_HIGHLIGHTING_THEME": "github-dark-dimmed",
     "DEFAULT_COLOR": {
         "color": "#768390",
         "backgroundColor": "#22282d"

src/themes.ts

@@ -1,5 +1,5 @@
 {
-    "SYNTAX_HIGHLIGHTING_THEME": "solarized-dark",
+    "SYNTAX_HIGHLIGHTING_THEME": "solarized-light",
     "DEFAULT_COLOR": {
         "color": "#657b83",
         "backgroundColor": "#fdf6e3"