Using exec.Cmd pipes for stdout and stderr which don't deadlock and a…#69
Open
agorman wants to merge 3 commits intobarasher:masterfrom
Open
Using exec.Cmd pipes for stdout and stderr which don't deadlock and a…#69agorman wants to merge 3 commits intobarasher:masterfrom
agorman wants to merge 3 commits intobarasher:masterfrom
Conversation
…re closed properly by call to wait
Contributor
Author
|
@barasher any thoughts on this? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 80.80% 79.46% -1.35%
==========================================
Files 2 2
Lines 297 297
==========================================
- Hits 240 236 -4
- Misses 40 42 +2
- Partials 17 19 +2
☔ View full report in Codecov by Sentry. |
Owner
|
I'm so sorry @agorman, I really did not have time to check it yet. I'm running out of time these last week's but it should be better in one or two weeks. |
Contributor
Author
|
@barasher thanks for the update. I'm not in a big hurry on this so don't stress about it. When you have some extra time take a look. Thanks! |
Contributor
Author
|
@barasher bump :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…re closed properly by call to wait
This would solve #68. I haven't fixed the failing tests yet and wanted to get your opinion.
Thanks!