Skip to content

Commit 1d8e362

Browse files
novas0x2ajsharpe
andauthored
runnable_binary: avoid using > on the output file (#1270)
Co-authored-by: James Sharpe <james.sharpe@zenotech.com>
1 parent c939c13 commit 1d8e362

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

foreign_cc/utils.bzl

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def runnable_binary(name, binary, foreign_cc_target, match_binary_name = False,
4444

4545
wrapper_cmd = """
4646
sed s@EXECUTABLE@$(rlocationpath {name})@g $(location @rules_foreign_cc//foreign_cc/private:runnable_binary_wrapper.sh) > tmp
47-
sed s@SH_BINARY_FILENAME@{sh_binary_filename}@g tmp > $@
47+
cp tmp $@
4848
"""
4949

5050
if hasattr(native, "package_relative_label"):
@@ -57,10 +57,7 @@ def runnable_binary(name, binary, foreign_cc_target, match_binary_name = False,
5757
name = name + "_wrapper",
5858
srcs = ["@rules_foreign_cc//foreign_cc/private:runnable_binary_wrapper.sh", name + "_fg"],
5959
outs = [name + "_wrapper.sh"],
60-
cmd = select({
61-
"@platforms//os:windows": wrapper_cmd.format(name = fg_label, sh_binary_filename = binary + ".exe" if match_binary_name else name),
62-
"//conditions:default": wrapper_cmd.format(name = fg_label, sh_binary_filename = binary if match_binary_name else name),
63-
}),
60+
cmd = wrapper_cmd.format(name = fg_label),
6461
tags = tags + ["manual"],
6562
)
6663

0 commit comments

Comments
 (0)