Skip to content

Calls to rm -rf and mkdir are improperly quoted #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
benjamin-branchware opened this issue Mar 30, 2025 · 1 comment
Open

Calls to rm -rf and mkdir are improperly quoted #1388

benjamin-branchware opened this issue Mar 30, 2025 · 1 comment

Comments

@benjamin-branchware
Copy link

benjamin-branchware commented Mar 30, 2025 •
edited
Loading

Calls to rm -rf and mkdir, such as in rm -rf $BUILD_TMPDIR and mkdir -p $INSTALLDIR are not properly quoted and therefore do not handle paths containing spaces. I would go so far as to consider this a security issue, as the generated script may end up force-deleting any directory on a user's system for which it has permission to do so.

This issue is most apparent on Windows systems, where paths containing spaces are commonplace.
@benjamin-branchware benjamin-branchware changed the title rules_foreign_cc should not depend on Bash rules_foreign_cc should not depend on Bash (add native Windows support) Mar 30, 2025
@benjamin-branchware benjamin-branchware changed the title rules_foreign_cc should not depend on Bash (add native Windows support) Calls to rm -rf and mkdir are improperly quoted Mar 31, 2025
@benjamin-branchware benjamin-branchware mentioned this issue Mar 31, 2025
Draft
@benjamin-branchware
Copy link
Author

Discussion continues in #1389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamin-branchware