-
-
Notifications
You must be signed in to change notification settings - Fork 694
go-protoc-bin failed: error executing GoProtocGen command #4317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We recently made it an error if a proto plugin fails to create files it claims to create to also masking errors. I don't know of any other changes. |
Thanks, I'll try and investigate if that is happening in my case. |
We're seeing a similar issue. I can't post the complete code, but here's a snippet:
On 0.53.0 this correctly creates:
But after upgrading to 0.54.0 the We have other targets that DO work, but this one has a |
After some investigation, I discovered the problem:
I'm not sure what the solution is, the first proto needs to be compiled with the grpc compiler, and it depends on the 2nd proto. But the change in 0.54.0 requires all compilers to create output for all files |
Any plans to create a |
yeah, I can create one later this week |
@linzhp @fmeum BCR still hast 0.54.0. Can a fix be published? 🙏 For cross-linking: connectrpc/connect-go#846 |
…4324) **What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** It's common for a `go_proto_library` to include proto files with and without service definitions at the same time. In this case, the gRPC plugins are needed, but some gRPC plugins don't generate the grpc.pb.go files if there is no service definition. Partially reverting #4287 to restore the previous behavior of creating an empty file **Which issues(s) does this PR fix?** Fixes #4317 **Other notes for review** --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Publishing: bazelbuild/bazel-central-registry#4626 Sorry for the delay |
Fixed my workflow, thank you! grpc-ecosystem/grpc-gateway#5594 |
Hi! I'm the maintainer of the grpc-gateway. It seems that something in v0.54.0 broke our protobuf generation. This auto-created PR is failing our bazel build. The error is:
I found this a bit hard to parse, but I think the salient part is
It doesn't say what exactly failed, though, so not sure how it broke. Here's the full build log: https://github.com/grpc-ecosystem/grpc-gateway/actions/runs/14474740731/job/40597503943?pr=5472. The command was
$ bazel test //...
The text was updated successfully, but these errors were encountered: