docs: added note about x/tools when using vet with nogo #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If golang.org/x/tools is not in the go.mod file, then you get import errors on the standard library when using nogo.
|
Hmm, this is certainly not the desired behavior. Could you provide steps to reproduce this as well as the error you are seeing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Documentation
What does this PR do? Why is it needed?
Makes it visible that there is a dependency on
golang.org/x/tools.If
golang.org/x/toolsis not in the go.mod file, then you get import errors on the standard library when using nogo.Other notes for review