Skip to content

Run buildifier to add explicit loads #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Run buildifier to add explicit loads #4345

wants to merge 5 commits into from

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented May 15, 2025

They will be required in Bazel 9.

@fmeum fmeum requested review from linzhp and jayconrod May 15, 2025 15:42
@fmeum
Copy link
Member Author

fmeum commented May 15, 2025

Blocked on #4339

They will be required in Bazel 9.
@fmeum
Copy link
Member Author

fmeum commented May 15, 2025

Loading from rules_cc forces us to rely on a modern version of protobuf, which in turn we need to make work via our deps macros, but that fails since we can't run protobuf's own deps macros.

@jayconrod Do you have an idea how to make this work without breaking too much? Bazel 9 won't have WORKSPACE at all, but we'll be stuck supporting it for a while.

@jayconrod
Copy link
Contributor

I'm not sure I understand all the subtleties of what's happening. If protobuf becomes a mandatory dependency, we need to add its transitive dependencies to go_rules_dependencies right? I guess we can't call its deps macro because we're loading it there. We could flatten and inline the contents of that deps macro maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants