Skip to content

Don't print warnings when testing utility functions #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Don't print warnings when testing utility functions #1403

wants to merge 1 commit into from

Conversation

cheister
Copy link
Collaborator

@cheister cheister commented Jul 7, 2025

Don't print test output for regular build.

bazel build //...

DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming com.android.support:appcompat-v7:aar:28.0.0 should be interpreted as com.android.support:appcompat-v7:28.0.0@aar
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming com.android.support:appcompat-v7:aar:28.0.0 should be interpreted as com.android.support:appcompat-v7:28.0.0@aar
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming org.mockito:mockito-core:jar:3.3.3 should be interpreted as org.mockito:mockito-core:3.3.3@jar
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming androidx.arch.core:core-testing:aar:2.1.0 should be interpreted as androidx.arch.core:core-testing:2.1.0@aar
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming org.mockito:mockito-core:pom:3.3.3 should be interpreted as org.mockito:mockito-core:3.3.3@pom
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming group:artifact:test-jar:1.2.3 should be interpreted as group:artifact:1.2.3@test-jar
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming groupId:artifactId:bundle:1.2.3 should be interpreted as groupId:artifactId:1.2.3@bundle
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming org.eclipse.aether:aether-api:jar:1.1.0 should be interpreted as org.eclipse.aether:aether-api:1.1.0@jar
DEBUG: rules_jvm_external/private/rules/v1_lock_file.bzl:123:18: Received different passwords for a@c1! Only using the first
DEBUG: rules_jvm_external/private/rules/v1_lock_file.bzl:116:22: Received multiple logins for machine 'c1'! Only using 'a'
DEBUG: rules_jvm_external/private/rules/v1_lock_file.bzl:123:18: Received different passwords for a@c1! Only using the first
DEBUG: rules_jvm_external/private/rules/v1_lock_file.bzl:116:22: Received multiple logins for machine 'c1'! Only using 'a'
DEBUG: rules_jvm_external/private/rules/v1_lock_file.bzl:116:22: Received multiple logins for machine 'c1'! Only using 'a1'
DEBUG: rules_jvm_external/private/rules/v1_lock_file.bzl:116:22: Received multiple logins for machine 'c1'! Only using 'a1'
DEBUG: rules_jvm_external/private/rules/v1_lock_file.bzl:116:22: Received multiple logins for machine 'c1'! Only using 'a1'
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming groupId:artifactId:test-jar:1.2.3 should be interpreted as groupId:artifactId:1.2.3@test-jar
DEBUG: rules_jvm_external/private/lib/coordinates.bzl:85:18: Assuming groupId:artifactId:bundle:1.2.3 should be interpreted as groupId:artifactId:1.2.3@bundle

cheister
cheister commented Jul 7, 2025
View reviewed changes
private/rules/maven_bom.bzl
@@ -78,7 +78,7 @@ def _maven_dependencies_bom_impl(ctx):
ctx,
coordinates = ctx.attr.maven_coordinates,
is_bom = True,
versioned_dep_coordinates = combined_deps + ["%s:%s:pom:%s" % (unpacked.group, unpacked.artifact, unpacked.version)],
versioned_dep_coordinates = combined_deps + ["%s:%s:%s@pom" % (unpacked.group, unpacked.artifact, unpacked.version)],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this change regardless of what we do with the rest or the PR

shs96c
shs96c reviewed Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the is_test parameter. We should be the only ones who see that since we're the only ones who are loading these install tags.

private/rules/maven_utils.bzl
@@ -94,6 +94,8 @@ def generate_pom(
substitutions.update({"{parent}": "".join(parts)})

deps = []
# print("versioned_dep_coordinates = {}".format(versioned_dep_coordinates))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be deleted

MODULE.bazel
@@ -356,7 +356,7 @@ dev_maven.install(
name = "jvm_import_test",
artifacts = [
"com.google.code.findbugs:jsr305:3.0.2",
"com.android.support:appcompat-v7:aar:28.0.0",
"com.android.support:appcompat-v7:28.0.0@aar",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c left review comments

@jin jin Awaiting requested review from jin jin will be requested when the pull request is marked ready for review jin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheister @shs96c