Require force_version for root module artifact to take precedence
#1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake precedence # Conflicts: # private/extensions/maven.bzl
|
Note, this builds on #1422 so only the commits after "fix a thinko" need to be reviewed as part of this PR. |
cheister
reviewed
Jul 21, 2025
| @@ -292,7 +301,7 @@ def _deduplicate_artifacts_with_root_priority(root_artifacts, non_root_artifacts | |||
| else: | |||
| warning_parts.append(maven_module) | |||
|
|
|||
| print("WARNING: The following maven modules appear in multiple sub-modules with potentially different versions. " + | |||
| print("WARNING: The following coordinates from `%s` appear in multiple sub-modules with potentially different versions. " % name + | |||
| "Consider adding one of these to your root module to ensure consistent versions:\n\t%s" % | |||
There was a problem hiding this comment.
Should this message be updated to tell people they'll need force_version=True for the coordinates in the root module?
cheister
reviewed
Jul 21, 2025
| @@ -18,6 +18,7 @@ maven.artifact( | |||
| exclusions = ["com.google.code.findbugs:jsr305"], | |||
| group = "com.google.guava", | |||
| version = "31.1-jre", | |||
| force_version = True, | |||
There was a problem hiding this comment.
nit: should force_version be in sorted order after exclusions?
cheister
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was concern expressed by some owners of sub-modules that deliberately contribute to the
mavenrepo that the behaviour of implicitly overriding artifacts by merely listing them in the root module would lead to users accidentally overriding those values. Instead, require the root module to useforce_versionto override the specific coordinate, which is more inline with the original intention offorce_version.