Skip to content

fix broken pre-commit hooks by upgrading isort #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

cj81499
Copy link
Contributor

@cj81499 cj81499 commented Feb 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

pre-commit fails to install isort

What is the new behavior?

pre-commit succesfully installs isort

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Relates to #1067

@cj81499 cj81499 requested a review from rickeylev as a code owner February 14, 2023 16:54
@google-cla
Copy link

google-cla bot commented Feb 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@f0rmiga
Copy link
Member

f0rmiga commented Feb 14, 2023

@cj81499 Could you sign the CLA, please?

@cj81499
Copy link
Contributor Author

cj81499 commented Feb 14, 2023

Working on it! I'm making changes on behalf of my company (Ocient) and I have a meeting scheduled with my manager (about getting it signed) later today.

@cj81499 cj81499 closed this Mar 21, 2023
@cj81499 cj81499 deleted the fix-isort-pre-commit branch March 21, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants