Skip to content

refactor: Run isort and black on all python files #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

dougthor42
Copy link
Collaborator

Run isort and black on all python files so that the pre-commit
hooks do not fail anymore.

It seems like most of the issues were quotation marks and vertical
whitespace.

Fixes #1674.

@dougthor42 dougthor42 changed the title refactor: Run isort and black on all python files Pre commit gh1674 refactor: Run isort and black on all python files Apr 17, 2024
def get_random_number():
return jsonify({'number': generate_random_number.generate_random_number()})
return jsonify({"number": generate_random_number.generate_random_number()})


"""Start the python web server"""
Copy link
Collaborator Author

@dougthor42 dougthor42 Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this docstring down to def main():

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -15,5 +15,7 @@
import random

"""Generate a random number"""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move docstring

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dougthor42 dougthor42 marked this pull request as ready for review April 17, 2024 18:57
@f0rmiga f0rmiga added this pull request to the merge queue Apr 17, 2024
Merged via the queue into bazel-contrib:main with commit 55af3eb Apr 17, 2024
4 checks passed
@dougthor42 dougthor42 deleted the pre-commit-gh1674 branch April 17, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit run --all-files fails on main branch
2 participants