-
-
Notifications
You must be signed in to change notification settings - Fork 597
refactor(pypi): use a macro to define whl_library targets #2347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pypi): use a macro to define whl_library targets #2347
Conversation
DIST_INFO_LABEL: ["site-packages/*.dist-info/**"], | ||
DATA_LABEL: ["data/**"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I would like to include extra folders here, what me and @arrdem discussed in #1730. It would be valuable to have those files so that the hub
repo can provide more filegroup
targets out of the box. This may make things easier where the annotations
API is heavily used by our users.
cc: @keith, not sure if this help in defining the cc_library
targets, but regardless, this may be a good step forward.
Summary:
This makes the code more maintainable by reducing the amount of tests
that are comparing BUILD.bazel outputs.