Skip to content

refactor(pypi): use a macro to define whl_library targets #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 28, 2024

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Oct 25, 2024

Summary:

  • refactor: Start implementing whl_library_targets
  • refactor: start using whl_library_targets macro
  • refactor: generate config settings in the new macro
  • refactor: copy_files in the new macro
  • refactor: move entry_point generation to the macro
  • refactor: move the py_library and whl generation to the new macro

This makes the code more maintainable by reducing the amount of tests
that are comparing BUILD.bazel outputs.

@aignas aignas marked this pull request as ready for review October 25, 2024 10:09
Comment on lines +41 to +42
DIST_INFO_LABEL: ["site-packages/*.dist-info/**"],
DATA_LABEL: ["data/**"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I would like to include extra folders here, what me and @arrdem discussed in #1730. It would be valuable to have those files so that the hub repo can provide more filegroup targets out of the box. This may make things easier where the annotations API is heavily used by our users.

cc: @keith, not sure if this help in defining the cc_library targets, but regardless, this may be a good step forward.

@aignas aignas enabled auto-merge October 28, 2024 02:16
@aignas aignas added this pull request to the merge queue Oct 28, 2024
Merged via the queue into bazel-contrib:main with commit 4623990 Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants