-
-
Notifications
You must be signed in to change notification settings - Fork 584
py_wheel: always generate zip64-capable wheels #2711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
zip64 is enabled by default, so shouldn't that obviate the need for forcing it to be enabled? |
@rickeylev for my case it doesnt seem to suffice.. this is the output of the failure for the current main (7d431d8), which then works with forcing zip64:
|
Oh hm. I think the usage of zip64 is inconsistent, depending on which zip APIs is used. ZipFile() says it defaults to allow_zip64=True. Meanwhile, ZipFile.open (the API used in this code), defaults to force_zip64=False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Direction LGTM, but see comment
I updated it to always set zip64. There's a wheel test with a hard coded hash, though, so that needs to be updated. |
Currently, there is no possibility to pass the force zip64 option to the wheel creation. This hinders creation of packages that contain >2Gb files (e.g. large projects with debug symbols).
To fix, always generate zip64 capable wheels. zip64 support is wide spread.