Skip to content

py_wheel: always generate zip64-capable wheels #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 9 commits into from
May 3, 2025
Merged

py_wheel: always generate zip64-capable wheels #2711

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
00765de
feat: Add force_zip64 option
devtbi Mar 26, 2025
bd36934
always set forceZip64=True
rickeylev Apr 20, 2025
3e90a1f
remove passing zip64 as cli
rickeylev Apr 20, 2025
134750a
Merge branch 'main' into main
rickeylev Apr 20, 2025
bd0114f
Merge branch 'main' into main
rickeylev May 2, 2025
9ab56c2
Update hash
rickeylev May 2, 2025
ed95960
Fix more hashes
rickeylev May 3, 2025
624e040
Fix another hash
rickeylev May 3, 2025
cf9e3dd
Fix test_publish hash
rickeylev May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ END_UNRELEASED_TEMPLATE

{#v0-0-0-changed}
### Changed
* Nothing changed.
* (py_wheel) py_wheel always creates zip64-capable wheel zips

{#v0-0-0-fixed}
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion tools/wheelmaker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def arcname_from(name):
hash = hashlib.sha256()
size = 0
with open(real_filename, "rb") as fsrc:
with self.open(zinfo, "w") as fdst:
with self.open(zinfo, "w", force_zip64=True) as fdst:
while True:
block = fsrc.read(2**20)
if not block:
Expand Down