feat(core): switch to script bootstrap as a default #3117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
force-pushed
the
check-script-default
branch
2 times, most recently
from
44578e9 to
55cb9c0
Compare
Work towards bazel-contrib#2156 Work towards bazel-contrib#2521 Relands bazel-contrib#2858 and reverts bazel-contrib#2968 Fixes bazel-contrib#2983
aignas
force-pushed
the
check-script-default
branch
from
55cb9c0 to
42dac20
Compare
|
FYI, @rickeylev, @alexeagle , we can continue talking about re-enabling the script=bootstrap by default for bazel 8+ here. Is there a good way to detect that we are running on that particular version with something else than |
rickeylev
reviewed
Sep 20, 2025
PEPs can take a long time, so I don't think we should wait on that.
Maybe. If the 1.2 release is coming soon, then waiting sounds OK. If it takes too long, though, then I think we'll just have to press ahead. At the least, we should wait until there exists some rule that can package them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
bootstrapscript implementation for bazel 8 and abovefor UNIX platforms.
DO NOT MERGE: this has to be discussed:
Work towards #2156
Work towards #2521
Relands #2858 and reverts #2968
Fixes #2983
Related:
rules_pkgto produce working tars is in Support packaging raw symlinks from declare_symlink bazelbuild/rules_pkg#929 that will be released in 1.2 (bump version to 1.2 bazelbuild/rules_pkg#977)