Use rules_jvm_external for internal dependencies#1786
Use rules_jvm_external for internal dependencies#1786jadenPete wants to merge 3 commits intobazel-contrib:masterfrom
Conversation
|
Quick comments:
I think I'm beginning to see some of the benefit of using Note that if/when #1785 lands, which should happen first (if we decide to merge it), both the |
|
Thank you for the comments! My bad, I've updated the description to follow that format. Working on splitting out the |
be4fe9f to
917d5f1
Compare
|
Ok, I've opened a separate PR for the Also, the tests should pass now. That PR needs to be merged before this one, so consider this PR to be stacked on that one and please ignore the first commit when reviewing it. |
It's my goal to remove `dev_deps`, and switching to `buildifier-prebuilt` gets us one step closer to doing that. It should also make CI faster.
917d5f1 to
aaf8620
Compare
Description
This PR is the second in a series to refactor the ruleset to use
rules_jvm_externalfor fetching all Maven artifacts.It deletes
scala/private/extensions/dev_deps.bzland refactors the ruleset to pull all internal dependencies (previously declared in that module) usingrules_jvm_external. It also makesrules_jvm_externala required dependency of the ruleset.Motivation
Please see this PR for more information on this initiative and the motivations behind it:
#1775